This revision was automatically updated to reflect the committed changes.
Closed by commit rL336785: [clangd] Upgrade logging facilities with levels and
formatv. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D4
sammccall updated this revision to Diff 154959.
sammccall added a comment.
Add workaround for formatv+error issues.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49008
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdUnit.cpp
clangd/CodeComplete.c
simark added a comment.
In https://reviews.llvm.org/D49008#1154196, @sammccall wrote:
> @simark - is it OK if I pick this up?
Yes, totally fine. I didn't have time to follow up on my patch, and I think
you did a great job here. I tested it, and I see that my main pain point was
addressed.
sammccall updated this revision to Diff 154402.
sammccall added a comment.
rebase
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49008
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdUnit.cpp
clangd/CodeComplete.cpp
clangd/Compiler.cpp
clangd/
hokein added a comment.
still LGTM.
The diff contains unrelated changes now.
Comment at: clangd/tool/ClangdMain.cpp:104
+llvm::cl::values(clEnumVal(Logger::Error, "Error messages only"),
+ clEnumVal(Logger::Info, "High level execution tracing"),
+
sammccall added inline comments.
Comment at: clangd/tool/ClangdMain.cpp:104
+llvm::cl::values(clEnumVal(Logger::Error, "Error messages only"),
+ clEnumVal(Logger::Info, "High level execution tracing"),
+ clEnumVal(Logger::Debug, "Low le
sammccall updated this revision to Diff 154391.
sammccall added a comment.
Herald added a subscriber: mgorny.
Name debug->verbose
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49008
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/cert/CMakeLists.txt
clang-tidy/cert/
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Nice, look good.
Comment at: clangd/tool/ClangdMain.cpp:104
+llvm::cl::values(clEnumVal(Logger::Error, "Error messages only"),
+ clEnumVal(Logger::Inf
sammccall added a comment.
This borrows from https://reviews.llvm.org/D44226 (log levels) which got
stalled for various reasons (@simark - is it OK if I pick this up?).
It doesn't actually split the LSP messages vs LSP message names into different
levels, but that's a simple followup.
Switching
sammccall created this revision.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, javed.absar,
ilya-biryukov.
log() is split into four functions:
- elog()/log()/vlog() have different severity levels, allowing filtering
- dlog() is a lazy macro which uses LLVM_DEBUG - it logs to t
10 matches
Mail list logo