[PATCH] D49120: [libc++] P0898R3 2 of 12: Implement header

2018-07-11 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter added inline comments. Comment at: include/concepts:175 +template +_LIBCPP_CONCEPT_DECL Same = __same_impl<_Tp, _Up> && __same_impl<_Up, _Tp>; + Quuxplusone wrote: > CaseyCarter wrote: > > Quuxplusone wrote: > > > Peanut gallery asks: From lines 166-

[PATCH] D49120: [libc++] P0898R3 2 of 12: Implement header

2018-07-10 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter updated this revision to Diff 154787. CaseyCarter added a comment. Qualify call to `__invoke_constexpr` in the definition of the `Invocable` concept. https://reviews.llvm.org/D49120 Files: CMakeLists.txt include/CMakeLists.txt include/__config include/concepts include/mod

[PATCH] D49120: [libc++] P0898R3 2 of 12: Implement header

2018-07-09 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone added inline comments. Comment at: include/concepts:175 +template +_LIBCPP_CONCEPT_DECL Same = __same_impl<_Tp, _Up> && __same_impl<_Up, _Tp>; + CaseyCarter wrote: > Quuxplusone wrote: > > Peanut gallery asks: From lines 166-171 it looks awfully like

[PATCH] D49120: [libc++] P0898R3 2 of 12: Implement header

2018-07-09 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter added inline comments. Comment at: include/concepts:175 +template +_LIBCPP_CONCEPT_DECL Same = __same_impl<_Tp, _Up> && __same_impl<_Up, _Tp>; + Quuxplusone wrote: > Peanut gallery asks: From lines 166-171 it looks awfully like > `__same_impl<_Tp, _

[PATCH] D49120: [libc++] P0898R3 2 of 12: Implement header

2018-07-09 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone added inline comments. Comment at: include/concepts:175 +template +_LIBCPP_CONCEPT_DECL Same = __same_impl<_Tp, _Up> && __same_impl<_Up, _Tp>; + Peanut gallery asks: From lines 166-171 it looks awfully like `__same_impl<_Tp, _Up>` is true if and onl

[PATCH] D49120: [libc++] P0898R3 2 of 12: Implement header

2018-07-09 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter added inline comments. Comment at: include/concepts:193 +#endif +#if 0 // FIXME: File LWG issue +requires(_From (&_Fn)()) { static_cast<_To>(_Fn()); }; I suppose it would have been a good idea to fix this before submitting the patch for review -

[PATCH] D49120: [libc++] P0898R3 2 of 12: Implement header

2018-07-09 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter created this revision. CaseyCarter added reviewers: mclow.lists, EricWF. Herald added subscribers: christof, modocache, mgorny. Piece number two contains the header, a bunch of "add a new header" changes, and LIT config to grok tests that need concepts (Thanks to @EricWF's similar ha