aaron.ballman added a comment.
In https://reviews.llvm.org/D49158#1172178, @juliehockett wrote:
> In https://reviews.llvm.org/D49158#1159882, @hokein wrote:
>
> > In https://reviews.llvm.org/D49158#1158327, @JonasToth wrote:
> >
> > > Is there a way to add a test, that would trigger the old
juliehockett added a comment.
In https://reviews.llvm.org/D49158#1159882, @hokein wrote:
> In https://reviews.llvm.org/D49158#1158327, @JonasToth wrote:
>
> > Is there a way to add a test, that would trigger the old segfault and show
> > that it does not happen anymore with this fix?
>
>
> +1,
hokein added a comment.
In https://reviews.llvm.org/D49158#1158327, @JonasToth wrote:
> Is there a way to add a test, that would trigger the old segfault and show
> that it does not happen anymore with this fix?
+1, we should have a minimal test case for this fix,
JonasToth added a comment.
Is there a way to add a test, that would trigger the old segfault and show that
it does not happen anymore with this fix?
https://reviews.llvm.org/D49158
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
JonasToth added inline comments.
Comment at: clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp:44
bool ) const {
- StringRef Name = Node->getIdentifier()->getName();
- llvm::StringMapConstIterator Pair =
juliehockett created this revision.
juliehockett added reviewers: aaron.ballman, hokein, ilya-biryukov.
juliehockett added a project: clang-tools-extra.
Herald added a subscriber: xazax.hun.
Bug 36150 found a segfault on mac when a CXXRecordDecl has no IdentifierInfo,
this fixes it.
