[PATCH] D49223: [AST] Check described template at structural equivalence check.

This revision was automatically updated to reflect the committed changes. Closed by commit rC339256: [AST] Check described template at structural equivalence check. (authored by balazske, committed by ). Changed prior to commit: https://reviews.llvm.org/D49223?vs=159458=159725#toc Repository:

[PATCH] D49223: [AST] Check described template at structural equivalence check.

balazske updated this revision to Diff 159458. balazske marked an inline comment as done. balazske added a comment. - Renamed methods, simplified code, comments updated. Repository: rC Clang https://reviews.llvm.org/D49223 Files: include/clang/AST/ASTStructuralEquivalence.h

[PATCH] D49223: [AST] Check described template at structural equivalence check.

a.sidorin accepted this revision. a.sidorin added a comment. Hi Balazs, I have only two nits. Otherwise, the patch is OK and can be committed without additional approval after the comments are fixed. Thank you! Comment at: lib/AST/ASTStructuralEquivalence.cpp:1500 +bool

[PATCH] D49223: [AST] Check described template at structural equivalence check.

balazske updated this revision to Diff 159279. balazske added a comment. - Rebase, common checks at ASTStructuralEquivalenceContext Repository: rC Clang https://reviews.llvm.org/D49223 Files: include/clang/AST/ASTStructuralEquivalence.h lib/AST/ASTStructuralEquivalence.cpp

[PATCH] D49223: [AST] Check described template at structural equivalence check.

a_sidorin added inline comments. Comment at: lib/AST/ASTStructuralEquivalence.cpp:958 + if (D1->isTemplated() != D2->isTemplated()) +return false; balazske wrote: > a_sidorin wrote: > > I think we can move the changes for both RecordDecl and FunctionDecl

[PATCH] D49223: [AST] Check described template at structural equivalence check.

balazske added inline comments. Comment at: lib/AST/ASTStructuralEquivalence.cpp:958 + if (D1->isTemplated() != D2->isTemplated()) +return false; a_sidorin wrote: > I think we can move the changes for both RecordDecl and FunctionDecl into > `Finish()`

[PATCH] D49223: [AST] Check described template at structural equivalence check.

a_sidorin added inline comments. Comment at: lib/AST/ASTStructuralEquivalence.cpp:958 + if (D1->isTemplated() != D2->isTemplated()) +return false; I think we can move the changes for both RecordDecl and FunctionDecl into `Finish()` and use

[PATCH] D49223: [AST] Check described template at structural equivalence check.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang https://reviews.llvm.org/D49223 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49223: [AST] Check described template at structural equivalence check.

martong added a reviewer: a_sidorin. martong added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D49223 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49223: [AST] Check described template at structural equivalence check.

balazske created this revision. Herald added a subscriber: cfe-commits. When checking a class or function the described class or function template is checked too. Improved test with symmetric check, added new tests. Repository: rC Clang https://reviews.llvm.org/D49223 Files: