This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rL336899: [clangd] log request/response messages with
method/ID/error at INFO level (authored by sammccall, committed by ).
Herald added a subscriber:
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: clangd/JSONRPCDispatcher.cpp:138
});
+ auto ID = 1;
+ log("--> {0}({1})", Method, ID);
nit I'd suggest putting this statement
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, ilya-biryukov.
Bodies are logged at VERBOSE level (since r336785), tweak the formatting.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49224
