greened closed this revision.
greened added a comment.
Fixed in r344901.
Repository:
rC Clang
https://reviews.llvm.org/D49244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Hmm, I'd really like a test for this but I'm not sure it's really testable
as-is because it depends on a non-default configuration value. :(
Repository:
rC Clang
greened added a comment.
Ping. This is impacting our ability to get clang functioning.
Repository:
rC Clang
https://reviews.llvm.org/D49244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
greened updated this revision to Diff 168472.
greened added a comment.
Updated to implement option 2. I'm not totally happy with passing a StringRef
just to check if it's non-empty but opted to reduce the size of the diff rather
than refactor a bunch of stuff.
Repository:
rC Clang
greened added a comment.
I agree that option 2 seems best. It's consistent with options overriding more
general configuration/environment variables and more specific options
overriding more general options. If it turns out option 1 is needed in the
future, it should be a simple change given
rsmith added a comment.
I think `-gcc-toolchain`, if specified, should simply be taken as the location
of the GCC toolchain; we should never go looking for it anywhere else if
`-gcc-toolchain` is specified. So I think the patch is not quite right as-is,
as it also affects that case. I think
greened added a comment.
Ping. It's been well over a month now. What's the best way to get this
reviewed?
Repository:
rC Clang
https://reviews.llvm.org/D49244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
greened added a comment.
Ping?
Repository:
rC Clang
https://reviews.llvm.org/D49244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
greened added a comment.
Ping?
Repository:
rC Clang
https://reviews.llvm.org/D49244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
greened added a comment.
Ping...
Repository:
rC Clang
https://reviews.llvm.org/D49244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
greened added a comment.
Ping.
Repository:
rC Clang
https://reviews.llvm.org/D49244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
greened added a comment.
Ping.
Repository:
rC Clang
https://reviews.llvm.org/D49244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
greened added a comment.
Ping.
Repository:
rC Clang
https://reviews.llvm.org/D49244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
greened created this revision.
greened added reviewers: rsmith, mcrosier, danalbert.
greened added a project: clang.
Herald added a subscriber: cfe-commits.
Previously, if clang was configured with -DGCC_INSTALL_PREFIX, then it would
not search a provided sysroot for a gcc install. This caused
14 matches
Mail list logo
