[PATCH] D49890: Clang-Tidy Export Problem

jwillemsen added a comment. I am trying to use run-clang-tidy on ACE/TAO (see https://github.com/DOCGroup/ACE_TAO) but it doesn't work, also the error reported here. When only running modernize-use-override I get a yaml file of 110167 lines but that can't also be applied using

[PATCH] D49890: Clang-Tidy Export Problem

ngzhian added a comment. I found this patch while searching for a similar problem I faced while tryin to use clang-tidy to fix some warnings in V8 (Chrome's JavaScript engine). The setup for our compilation is as such: - basedir - src/ - out/ -arch1/ - .o files, generated files

[PATCH] D49890: Clang-Tidy Export Problem

kfunk added a comment. Is someone willing to pick up this patch again? It's still an issue. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49890/new/ https://reviews.llvm.org/D49890 ___ cfe-commits

[PATCH] D49890: Clang-Tidy Export Problem

TheAhmad added a comment. Hi @alexfh, I have attached the compilation database for `MPlayer-1.3.0`.F7659818: compile_commands.json As can be seen, the paths are relative. To answer your comments I need more time. I do not remember the exact details. I will

[PATCH] D49890: Clang-Tidy Export Problem

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. In D49890#1200061 , @TheAhmad wrote: > In D49890#1182556 , @alexfh wrote: > > > Could you describe

[PATCH] D49890: Clang-Tidy Export Problem

TheAhmad added a comment. In https://reviews.llvm.org/D49890#1182556, @alexfh wrote: > Could you describe the specific problem you're solving and provide an > example? As mentioned by others, a test would be very welcome as well. Sorry for so much delay, @alexfh. I didn't see your comment. I

[PATCH] D49890: Clang-Tidy Export Problem

alexfh added a comment. Could you describe the specific problem you're solving and provide an example? As mentioned by others, a test would be very welcome as well. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49890 ___

[PATCH] D49890: Clang-Tidy Export Problem

TheAhmad updated this revision to Diff 157846. TheAhmad marked 4 inline comments as done. TheAhmad added a comment. auto used at line 612. auto removed at line 614. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49890 Files: ClangTidy.cpp Index: ClangTidy.cpp

[PATCH] D49890: Clang-Tidy Export Problem

JonasToth added a comment. Actually, maybe this patch is relevant for clang-tooling itself (where the compilation-database stuff actually is). @alexfh what is your opinion on that? `llvm/tools/clang/unittests/Tooling/CompilationDatabaseTest.cpp` This is the path for the unittests there.

[PATCH] D49890: Clang-Tidy Export Problem

JonasToth added inline comments. Comment at: ClangTidy.cpp:614 + vfs::FileSystem = *Files->getVirtualFileSystem(); + auto InitialWorkingDir = FileSystem.getCurrentWorkingDirectory(); + if (!InitialWorkingDir) TheAhmad wrote: > Eugene.Zelenko wrote: > > Type

[PATCH] D49890: Clang-Tidy Export Problem

TheAhmad added a comment. > Also, tests. What should I provide for tests? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49890 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49890: Clang-Tidy Export Problem

TheAhmad added a comment. The most comprehensive fix is to support all possible valid compilation databases. The current fix is the fastest one. > Can you just make clang-tidy respect the directory value? This is exactly what I did. I prepended the directory value to the file value and stored

[PATCH] D49890: Clang-Tidy Export Problem

lebedev.ri added a comment. In https://reviews.llvm.org/D49890#1178211, @JonasToth wrote: > In https://reviews.llvm.org/D49890#1178103, @lebedev.ri wrote: > > > I'm not sure what this differential *actually* does. > > > This is a follow up from this discussion on the mailing list: >

[PATCH] D49890: Clang-Tidy Export Problem

JonasToth added inline comments. Comment at: ClangTidy.cpp:612 + + std::unique_ptr Files = + make_unique(FileSystemOptions()); in this case you can use `auto` again, because the type of the `unique_ptr` is clear from the `make_unique` call. Repository:

[PATCH] D49890: Clang-Tidy Export Problem

JonasToth added a comment. In https://reviews.llvm.org/D49890#1178103, @lebedev.ri wrote: > I'm not sure what this differential *actually* does. This is a follow up from this discussion on the mailing list:

[PATCH] D49890: Clang-Tidy Export Problem

lebedev.ri added a comment. Also, please upload the patches with full context (`-U9`), and the patch is misformed, the `ClangTidy.cpp` isn't in the root directory. Also, tests. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49890

[PATCH] D49890: Clang-Tidy Export Problem

lebedev.ri added a comment. I'm not sure what this differential *actually* does. That being said https://clang.llvm.org/docs/JSONCompilationDatabase.html#format > directory: The working directory of the compilation. All paths specified in > the command or file fields must be either absolute or

[PATCH] D49890: Clang-Tidy Export Problem

TheAhmad updated this revision to Diff 157676. TheAhmad marked 4 inline comments as done. TheAhmad added a comment. Used make_pair instead of constructor call. Used unique_ptr. Used named cast. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49890 Files: ClangTidy.cpp

[PATCH] D49890: Clang-Tidy Export Problem

TheAhmad updated this revision to Diff 157667. TheAhmad marked an inline comment as done. TheAhmad added a comment. Added auto at line 612. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49890 Files: ClangTidy.cpp Index: ClangTidy.cpp

[PATCH] D49890: Clang-Tidy Export Problem

JonasToth added inline comments. Comment at: ClangTidy.cpp:612 + + FileManager *Files = new FileManager(FileSystemOptions()); + vfs::FileSystem = *Files->getVirtualFileSystem(); Eugene.Zelenko wrote: > You could use auto here, because type is in new

[PATCH] D49890: Clang-Tidy Export Problem

Eugene.Zelenko added inline comments. Comment at: ClangTidy.cpp:612 + + FileManager *Files = new FileManager(FileSystemOptions()); + vfs::FileSystem = *Files->getVirtualFileSystem(); You could use auto here, because type is in new statement.

[PATCH] D49890: Clang-Tidy Export Problem

TheAhmad accepted this revision. TheAhmad marked 3 inline comments as done. TheAhmad added a comment. This revision is now accepted and ready to land. Thanks Eugene! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49890 ___

[PATCH] D49890: Clang-Tidy Export Problem

TheAhmad updated this revision to Diff 157623. TheAhmad added a comment. Ran Clang Format. Redundant Braces Removed. Used auto. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49890 Files: ClangTidy.cpp Index: ClangTidy.cpp

[PATCH] D49890: Clang-Tidy Export Problem

Eugene.Zelenko added inline comments. Comment at: ClangTidy.cpp:620 + llvm::StringMap SingleErrors; + for (const ClangTidyError : Errors) { +if (!Error.BuildDirectory.empty()) { You could use auto, since it's iterator over container.

[PATCH] D49890: Clang-Tidy Export Problem

Eugene.Zelenko added inline comments. Comment at: ClangTidy.cpp:627 +Files->makeAbsolutePath(ErrorAbsoluteFilePath); +if (SingleErrors.find(ErrorAbsoluteFilePath) == SingleErrors.end()) +{ Please run Clang-format. Repository: rCTE Clang Tools

[PATCH] D49890: Clang-Tidy Export Problem

TheAhmad created this revision. TheAhmad added a reviewer: alexfh. TheAhmad added a project: clang-tools-extra. Hi. Clang tidy has problem with compile command databases that do not use necassarily absolute file paths. This is common in many projects that use makefiles as the build system,