[PATCH] D50147: clang-format: support external styles

MyDeveloperDay added a comment. I tend to agree, I'm not keen on the silent searching for the files.. this happens too much as it is, with Microsoft releasing VisualStudio with a clang-format.exe (v5.0), I suddenly find that binary is in my path, then all of a sudden all the 5.0 bugs we fixed

[PATCH] D50147: clang-format: support external styles

sammccall added a comment. In D50147#1751198 , @Typz wrote: > >> In our case, we actually have more than one "standard" style, a > >> combination of various OS (linux, windows, macos), and not a very strong > >> control on user computers. So we cannot

[PATCH] D50147: clang-format: support external styles

Typz added a comment. In D50147#1648786 , @sammccall wrote: > > First and forehand, I have a problem to solve in my organization : we have > > many projects, and maintaining the config file in some many repositories is > > not practical. > > In some

[PATCH] D50147: clang-format: support external styles

MyDeveloperDay added a comment. but perhaps I'm really just agreeing to @sammccall 's suggestion of "-style=" which kind of feels sufficient to me.. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50147/new/ https://reviews.llvm.org/D50147

[PATCH] D50147: clang-format: support external styles

MyDeveloperDay added a comment. I am not opposed to this idea, I actually think this has some mileage based on a use case I've encountered: our team tends to use windows builds of clang-format from (https://llvm.org/builds/) because its easy to distribute the installer, this is ok but

[PATCH] D50147: clang-format: support external styles

sammccall added a subscriber: MyDeveloperDay. sammccall added a comment. Sorry about the long delays in responses. I don't think the feature, as you want to scope it, belongs in clang-format. @klimek @MyDeveloperDay may have different opinions. In D50147#1533892

[PATCH] D50147: clang-format: support external styles

Typz added a comment. ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50147/new/ https://reviews.llvm.org/D50147 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50147: clang-format: support external styles

Typz added a comment. In D50147#157 , @sammccall wrote: > One thing that's unclear to me is whether your aim is to > > 1. solve a concrete problem for your organization > 2. solve a family of problems for similar organizations > 3. add a new way of

[PATCH] D50147: clang-format: support external styles

sammccall added a comment. One thing that's unclear to me is whether your aim is to 1. solve a concrete problem for your organization 2. solve a family of problems for similar organizations 3. add a new way of configuring styles for many types of users/projects If it's 1) I think this is very

[PATCH] D50147: clang-format: support external styles

Typz added a comment. ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50147/new/ https://reviews.llvm.org/D50147 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50147: clang-format: support external styles

Typz updated this revision to Diff 201693. Typz marked 3 inline comments as done. Typz added a comment. Herald added subscribers: ormris, mgorny. - Rebased - Adapt styles search path to platform conventions - Allow customizing search path at compile time - Allow overriding search path at runtime

[PATCH] D50147: clang-format: support external styles

Typz added a comment. Herald added a project: clang. In D50147#1310146 , @sammccall wrote: > In D50147#1309880 , @Typz wrote: > > > ping? > > > Sorry for losing track of this. > > I think `-style=` is a logical

[PATCH] D50147: clang-format: support external styles

sammccall added a comment. In D50147#1309880 , @Typz wrote: > ping? Sorry for losing track of this. I think `-style=` is a logical extension of the current options. I'm less sure of supporting it in BasedOnStyle, but happy to go either way. Referring

[PATCH] D50147: clang-format: support external styles

Typz added a comment. ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50147/new/ https://reviews.llvm.org/D50147 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50147: clang-format: support external styles

Typz added a comment. In https://reviews.llvm.org/D50147#1272742, @sammccall wrote: > Being able to discover the right style from the filesystem is powerful, and > if I was going to use this flag, I'd consider symlinking the style-file to > `subproject/.clang_format` instead. That way the

[PATCH] D50147: clang-format: support external styles

sammccall added a comment. In https://reviews.llvm.org/D50147#1279056, @Typz wrote: > In https://reviews.llvm.org/D50147#1272742, @sammccall wrote: > > > The idea here does seem to be a natural extension of -style, at least for > > the case when the arg is a filename directly. I'm not opposed,

[PATCH] D50147: clang-format: support external styles

Typz added a comment. In https://reviews.llvm.org/D50147#1272742, @sammccall wrote: > The idea here does seem to be a natural extension of -style, at least for the > case when the arg is a filename directly. I'm not opposed, happy to review > this. > > I do want to probe the use case a bit

[PATCH] D50147: clang-format: support external styles

sammccall added a comment. The idea here does seem to be a natural extension of -style, at least for the case when the arg is a filename directly. I'm not opposed, happy to review this. I do want to probe the use case a bit though: we have found that configuring via -style= doesn't scale that

[PATCH] D50147: clang-format: support external styles

Typz added a comment. In https://reviews.llvm.org/D50147#1244237, @krasimir wrote: > I don't understand the use-case this patch is realizing. Suppose I have a > bunch of projects that have to share a format style. Then I can checkout them > under a common root directory and put an appropriate

[PATCH] D50147: clang-format: support external styles

krasimir added a comment. I don't understand the use-case this patch is realizing. Suppose I have a bunch of projects that have to share a format style. Then I can checkout them under a common root directory and put an appropriate .clang-format file there. Repository: rC Clang

[PATCH] D50147: clang-format: support external styles

Typz added a comment. clang-format does indeed support .clang-format, which is great for *isolated* projects, and which is not affected by this patch. This patch addresses the issue of *centralizing* the definition of styles, e.g. allowing individual projects to reference externally defined

[PATCH] D50147: clang-format: support external styles

acoomans added a comment. Doesn’t clang-format support project-based //.clang-format// or //_clang-format//? How do they play with this diff? Repository: rC Clang https://reviews.llvm.org/D50147 ___ cfe-commits mailing list

[PATCH] D50147: clang-format: support external styles

Typz created this revision. Typz added reviewers: krasimir, djasper, klimek. Herald added a subscriber: acoomans. This patch allows defining external styles, which can be used exactly like the embedded styles (llvm, google, mozilla...). These styles are clang-format files installed either