This revision was automatically updated to reflect the committed changes.
Closed by commit rL339543: [clangd] Support textEdit in addition to insertText.
(authored by kadircet, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50449
Files:
kadircet updated this revision to Diff 160303.
kadircet added a comment.
- Rebase.
- Resolve discussions.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50449
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/SourceCode.cpp
clangd/SourceCode.h
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for the change!
Could we add an option to clangd to switch it on? (VSCode does not work, but
our hacked-up ycm integration seems to work, right?)
kadircet added inline comments.
Comment at: clangd/CodeComplete.cpp:1310
+ // other.
+ for (const auto : FixIts) {
+if (IsRangeConsecutive(FixIt.range, LSP.textEdit->range)) {
ilya-biryukov wrote:
> Maybe keep the `reserve` call? (we could reserve one
kadircet updated this revision to Diff 160073.
kadircet marked 5 inline comments as done.
kadircet added a comment.
Herald added a subscriber: mgrang.
- Resolve discussions.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50449
Files:
clangd/CodeComplete.cpp
ilya-biryukov added inline comments.
Comment at: clangd/CodeComplete.cpp:289
}
+ std::stable_sort(Completion.FixIts.begin(), Completion.FixIts.end(),
+ [](const TextEdit , const TextEdit ) {
We shouldn't have
kadircet created this revision.
kadircet added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric.
Completion replies contains textEdits as well. Note that this change
relies on https://reviews.llvm.org/D50443.
Repository:
rCTE Clang Tools
