hans added a comment.
In https://reviews.llvm.org/D50534#1225591, @xbolva00 wrote:
> is this fixed in 7.0 release branch too?
>
> @hans
I've merged it in r341529 now. Thanks for letting me know.
Repository:
rCXX libc++
https://reviews.llvm.org/D50534
xbolva00 added subscribers: hans, xbolva00.
xbolva00 added a comment.
is this fixed in 7.0 release branch too?
@hans
Repository:
rCXX libc++
https://reviews.llvm.org/D50534
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX340609: [libc++] Fix handling of negated character classes
in regex (authored by ldionne, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50534?vs=160169&id=162377#toc
Repository:
timshen accepted this revision.
timshen added a comment.
This revision is now accepted and ready to land.
That looks more correct to me, thanks! Although I'm still puzzled by the empty
check at all, it's clearly an improvement.
Repository:
rCXX libc++
https://reviews.llvm.org/D50534
_
ldionne added a comment.
In https://reviews.llvm.org/D50534#1194664, @timshen wrote:
> I'm not fully equipped with the context right now, but something doesn't add
> up. if `__neg_chars_.empty()` check is removed, the `(__neg_mask_ == 0)`
> above should be removed too. They have to be consisten
ldionne updated this revision to Diff 160169.
ldionne added a comment.
Rewrite the patch in light of timshen's comment, and add tests.
Repository:
rCXX libc++
https://reviews.llvm.org/D50534
Files:
libcxx/include/regex
libcxx/test/std/re/re.alg/re.alg.match/inverted_character_classes.pas
timshen added a comment.
I'm not fully equipped with the context right now, but something doesn't add
up. if `__neg_chars_.empty()` check is removed, the `(__neg_mask_ == 0)` above
should be removed too. They have to be consistent.
However, there is more weirdness in it. The comment above descr
ldionne added a comment.
The changeset that introduced this regression was reviewed as
https://reviews.llvm.org/D37955. @timshen, I'm curious to understand why you
or'ed with `__neg_chars_.empty()` when initializing `__in_neg_chars`. The
logic's not clear to me, and my tests seem to show that t
ldionne created this revision.
ldionne added reviewers: mclow.lists, timshen.
Herald added a reviewer: EricWF.
Herald added subscribers: cfe-commits, dexonsmith, christof.
This commit fixes a regression introduced in r316095, where we don't match
inverted character classes when there's no negated
