[PATCH] D51090: [clangd] Add index benchmarks

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE342026: [clangd] Add index benchmarks (authored by omtcyfz, committed by ). Changed prior to commit: https://reviews.llvm.org/D51090?vs=165023&id=165024#toc Repository: rL LLVM https://reviews.llv

[PATCH] D51090: [clangd] Add index benchmarks

This revision was automatically updated to reflect the committed changes. Closed by commit rL342026: [clangd] Add index benchmarks (authored by omtcyfz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51090?vs=165023&id=165025#toc Rep

[PATCH] D51090: [clangd] Add index benchmarks

kbobyrev updated this revision to Diff 165023. kbobyrev marked an inline comment as done. https://reviews.llvm.org/D51090 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/benchmarks/CMakeLists.txt clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp clang-tools-ex

[PATCH] D51090: [clangd] Add index benchmarks

lebedev.ri accepted this revision. lebedev.ri added a comment. In https://reviews.llvm.org/D51090#1230659, @kbobyrev wrote: > Add `--benchmark_min_time=0.01` to prevent testing time increase. Thanks! https://reviews.llvm.org/D51090 ___ cfe-commit

[PATCH] D51090: [clangd] Add index benchmarks

kbobyrev updated this revision to Diff 164895. kbobyrev added a comment. Add `--benchmark_min_time=0.01` to prevent testing time increase. https://reviews.llvm.org/D51090 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/benchmarks/CMakeLists.txt clang-tools-extra/cl

[PATCH] D51090: [clangd] Add index benchmarks

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D51090#1230582, @lebedev.ri wrote: > In https://reviews.llvm.org/D51090#1230579, @kbobyrev wrote: > > > The only problem left is that I'm not sure how to run b

[PATCH] D51090: [clangd] Add index benchmarks

lebedev.ri added a comment. In https://reviews.llvm.org/D51090#1230629, @sammccall wrote: > In https://reviews.llvm.org/D51090#1230582, @lebedev.ri wrote: > > > In https://reviews.llvm.org/D51090#1230579, @kbobyrev wrote: > > > > > The only problem left is that I'm not sure how to run binary whic

[PATCH] D51090: [clangd] Add index benchmarks

kbobyrev updated this revision to Diff 164887. kbobyrev added a comment. Find a hacky workaround to call `IndexBenchmark` binary. https://reviews.llvm.org/D51090 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/benchmarks/CMakeLists.txt clang-tools-extra/clangd/benc

[PATCH] D51090: [clangd] Add index benchmarks

lebedev.ri added a comment. In https://reviews.llvm.org/D51090#1230579, @kbobyrev wrote: > The only problem left is that I'm not sure how to run binary which is not > under bin (`IndexBenchmark`) using llvm-lit. But it's a //benchmark//.. What use could be from running it as part of the _test

[PATCH] D51090: [clangd] Add index benchmarks

kbobyrev updated this revision to Diff 164881. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. The only problem left is that I'm not sure how to run binary which is not under bin (`IndexBenchmark`) using llvm-lit. https://reviews.llvm.org/D51090 Files: clang-tools-extra/

[PATCH] D51090: [clangd] Add index benchmarks

kbobyrev updated this revision to Diff 164848. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Address few comments (not all of them for now, though). https://reviews.llvm.org/D51090 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/benchmarks/CMak

[PATCH] D51090: [clangd] Add index benchmarks

sammccall added a comment. Nice and simple :-) Looks good, just some details. Comment at: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp:1 +//===--- DexBenchmark.cpp - DexIndex benchmarks -*- C++ -*-===// +// rename? (it's not just dex

[PATCH] D51090: [clangd] Add index benchmarks

kbobyrev updated this revision to Diff 164414. kbobyrev added a comment. Sync with HEAD https://reviews.llvm.org/D51090 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/benchmarks/CMakeLists.txt clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp Index: clang-to

[PATCH] D51090: [clangd] Add index benchmarks

kbobyrev updated this revision to Diff 163821. kbobyrev edited the summary of this revision. kbobyrev added a comment. - Rebase on top of new code - Simplify code structure and get rid of global state (except for two filenames coming from `main()`) The only problem now is that the generated outp

[PATCH] D51090: [clangd] Add index benchmarks

kbobyrev updated this revision to Diff 162381. kbobyrev added a comment. Rebase on top of parent patch. https://reviews.llvm.org/D51090 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/benchmarks/CMakeLists.txt clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp

[PATCH] D51090: [clangd] Add index benchmarks

kbobyrev planned changes to this revision. kbobyrev added a comment. The current diff is rather messy and it is also blocked by the parent revision (https://reviews.llvm.org/D50894). It is likely to change if the parent CMake structure is changed. https://reviews.llvm.org/D51090 ___

[PATCH] D51090: [clangd] Add index benchmarks

kbobyrev created this revision. kbobyrev added reviewers: ioeric, ilya-biryukov, sammccall. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, mgorny. This patch introduces index benchmarks on top of the proposed LLVM benchmark pull. The