[PATCH] D51190: [AttrDocs]: document gnu_inline function attribute

rupprecht added a comment. BTW, seems like these docs have tests that weren't updated. Fixed with https://reviews.llvm.org/rL341002, but please take a look if that's not the right fix. Repository: rL LLVM https://reviews.llvm.org/D51190 ___ cfe

[PATCH] D51190: [AttrDocs]: document gnu_inline function attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rL340987: [AttrDocs]: document gnu_inline function attribute (authored by nickdesaulniers, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D51190 Fi

[PATCH] D51190: [AttrDocs]: document gnu_inline function attribute

rsmith added a comment. Looks good, thanks for improving our documentation! Repository: rC Clang https://reviews.llvm.org/D51190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51190: [AttrDocs]: document gnu_inline function attribute

nickdesaulniers updated this revision to Diff 163215. nickdesaulniers added a comment. - link to correct doc - explicitly mention extern inline - s/c89/GNU inline extension/g and mention -std=gnu89/-fgnu89-inline - Take rsmith's sugguested wording. Add info about __GNUC_STDC_INLINE__. - some final

[PATCH] D51190: [AttrDocs]: document gnu_inline function attribute

rsmith added inline comments. Comment at: include/clang/Basic/AttrDocs.td:3518 +the behavior of ``inline`` in both C99 inline semantics and C++ inline +semantics). + Might be useful to be a bit more explicit about how it differs: > [...] is just a hint. In parti

[PATCH] D51190: [AttrDocs]: document gnu_inline function attribute

nickdesaulniers updated this revision to Diff 162908. nickdesaulniers added a comment. - Take rsmith's sugguested wording. Add info about __GNUC_STDC_INLINE__. Repository: rC Clang https://reviews.llvm.org/D51190 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td Index:

[PATCH] D51190: [AttrDocs]: document gnu_inline function attribute

rsmith added inline comments. Comment at: include/clang/Basic/AttrDocs.td:3514-3516 +(possibly due to being referred to by function pointer), then no out of line +definition will be emitted (instead of c99's behaviour of always emitting an +out of line definition). --

[PATCH] D51190: [AttrDocs]: document gnu_inline function attribute

nickdesaulniers updated this revision to Diff 162761. nickdesaulniers added a comment. - s/c89/GNU inline extension/g and mention -std=gnu89/-fgnu89-inline Repository: rC Clang https://reviews.llvm.org/D51190 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td Index: inc

[PATCH] D51190: [AttrDocs]: document gnu_inline function attribute

efriedma added a comment. Thanks for taking the time to write documentation. The phrase "C89 convention" is misleading; the original ISO C standard doesn't define the inline keyword at all. Maybe something along the lines of "GNU inline extension". And maybe mention it's the default with -std

[PATCH] D51190: [AttrDocs]: document gnu_inline function attribute

nickdesaulniers updated this revision to Diff 162752. nickdesaulniers added a comment. - explicitly mention extern inline Repository: rC Clang https://reviews.llvm.org/D51190 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td Index: include/clang/Basic/AttrDocs.td =

[PATCH] D51190: [AttrDocs]: document gnu_inline function attribute

nickdesaulniers updated this revision to Diff 162291. nickdesaulniers added a comment. - link to correct doc Repository: rC Clang https://reviews.llvm.org/D51190 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td Index: include/clang/Basic/AttrDocs.td ==

[PATCH] D51190: [AttrDocs]: document gnu_inline function attribute

nickdesaulniers created this revision. nickdesaulniers added a reviewer: rsmith. Herald added a subscriber: cfe-commits. This wasn't documented https://clang.llvm.org/docs/AttributeReference.html, and briefly mentioned https://clang.llvm.org/docs/UsersManual.html#differences-between-various-stan