ioeric updated this revision to Diff 162897.
ioeric marked 3 inline comments as done.
ioeric retitled this revision from "[clangd] Support multiple #include headers
in one symbol." to "[clangd] *Prototype* Support multiple #include headers in
one symbol.".
ioeric edited the summary of this
sammccall added a comment.
Nice!
We could reduce the scope of this patch somewhat by ignoring file proximity and
just switching to return the most popular header. This would be a solid
improvement over current behavior, and provide the infrastructure for the
file-proximity approach.
ioeric updated this revision to Diff 162650.
ioeric added a comment.
- minor cleanup
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51291
Files:
clangd/CodeComplete.cpp
clangd/Quality.cpp
clangd/Quality.h
clangd/index/Index.cpp
clangd/index/Index.h
ioeric added a comment.
@sammccall The code still needs cleanup but should be useful for providing
high-level feedback, which I would like to get before moving further. Thanks!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51291
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
Currently, a symbol can have only one #include header attached, which
might not work well if the symbol can be imported via different
