[PATCH] D51297: [docs] Create a guide for Vim users on how to setup Clangd

2018-09-10 Thread Eric Liu via Phabricator via cfe-commits
ioeric added a comment. In https://reviews.llvm.org/D51297#1228441, @kbobyrev wrote: > In https://reviews.llvm.org/D51297#1225546, @ilya-biryukov wrote: > > > I would stamp this from my side, but concerns whether we should recommend > > YCM's LSP-based completer instead are probably still there.

[PATCH] D51297: [docs] Create a guide for Vim users on how to setup Clangd

2018-09-09 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev added a comment. In https://reviews.llvm.org/D51297#1225546, @ilya-biryukov wrote: > I would stamp this from my side, but concerns whether we should recommend > YCM's LSP-based completer instead are probably still there. > @sammccall, WDYT? Yes, I can see your point, but I think this

[PATCH] D51297: [docs] Create a guide for Vim users on how to setup Clangd

2018-09-05 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. I would stamp this from my side, but concerns whether we should recommend YCM's LSP-based completer instead are probably still there. @sammccall, WDYT? https://reviews.llvm.org/D51297 ___ cfe-commits mailing list cfe-

[PATCH] D51297: [docs] Create a guide for Vim users on how to setup Clangd

2018-09-05 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev added a comment. Ping; this one just redirects to the appropriate Wiki entry on GitHub. https://reviews.llvm.org/D51297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51297: [docs] Create a guide for Vim users on how to setup Clangd

2018-08-30 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 163306. kbobyrev added a comment. Now that there's a Wiki page on how to use Clangd with LanguageClient-neovim, we should just redirect (Neo)Vim users to that page. https://reviews.llvm.org/D51297 Files: clang-tools-extra/docs/clangd.rst Index: clang-

[PATCH] D51297: [docs] Create a guide for Vim users on how to setup Clangd

2018-08-28 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 162808. kbobyrev marked an inline comment as done. kbobyrev added a comment. Complete two last paragraphs, address few comments. We haven't figured out whether we should suggest using this particular workflow at this point, but we're discussing the options.

[PATCH] D51297: [docs] Create a guide for Vim users on how to setup Clangd

2018-08-27 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added a comment. Very nice :) I will try to get it running for vim 8.0 on ubuntu 18.04 (hopefully this week!) and share if i had success :) Am 27.08.2018 um 16:57 schrieb Kirill Bobyrev via Phabricator: > kbobyrev added a comment. > > In https://reviews.llvm.org/D51297#1214321, @Jona

[PATCH] D51297: [docs] Create a guide for Vim users on how to setup Clangd

2018-08-27 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev added a comment. In https://reviews.llvm.org/D51297#1214321, @JonasToth wrote: > Very nice! Switching to clangd means that YCM is not necessary anymore? Hi! Yeah, basically I wanted to follow up on the mailing list after I get some docs in, but you found this earlier :) The good thin

[PATCH] D51297: [docs] Create a guide for Vim users on how to setup Clangd

2018-08-27 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. In https://reviews.llvm.org/D51297#1214313, @kbobyrev wrote: > In https://reviews.llvm.org/D51297#1214297, @ilya-biryukov wrote: > > > Do we want to keep the docs for different editors separate or do we want to > > put them all into a single page in case we add mor

[PATCH] D51297: [docs] Create a guide for Vim users on how to setup Clangd

2018-08-27 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev added inline comments. Comment at: clang/docs/ClangFormat.rst:97 +Clangd Integration +== ioeric wrote: > We could recomend formatting with clangd in clangd doc, but advertising here > seems a bit odd. I'd suggest dropping this. > > An

[PATCH] D51297: [docs] Create a guide for Vim users on how to setup Clangd

2018-08-27 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added a comment. Very nice! Switching to clangd means that YCM is not necessary anymore? https://reviews.llvm.org/D51297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51297: [docs] Create a guide for Vim users on how to setup Clangd

2018-08-27 Thread Eric Liu via Phabricator via cfe-commits
ioeric added a comment. In https://reviews.llvm.org/D51297#1214297, @ilya-biryukov wrote: > Do we want to keep the docs for different editors separate or do we want to > put them all into a single page in case we add more editors? > I would vouch for keeping them on a single page, but that's no

[PATCH] D51297: [docs] Create a guide for Vim users on how to setup Clangd

2018-08-27 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev added a comment. In https://reviews.llvm.org/D51297#1214297, @ilya-biryukov wrote: > Do we want to keep the docs for different editors separate or do we want to > put them all into a single page in case we add more editors? > I would vouch for keeping them on a single page, but that's

[PATCH] D51297: [docs] Create a guide for Vim users on how to setup Clangd

2018-08-27 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. Do we want to keep the docs for different editors separate or do we want to put them all into a single page in case we add more editors? I would vouch for keeping them on a single page, but that's not a strong opinion. Wonder what other people think? https://revi

[PATCH] D51297: [docs] Create a guide for Vim users on how to setup Clangd

2018-08-27 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev planned changes to this revision. kbobyrev added a comment. I need to - Complete last two sections - Make sure everything is rendered as expected - Proof-read the text https://reviews.llvm.org/D51297 ___ cfe-commits mailing list cfe-commit

[PATCH] D51297: [docs] Create a guide for Vim users on how to setup Clangd

2018-08-27 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev created this revision. kbobyrev added reviewers: ioeric, ilya-biryukov, sammccall. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. https://reviews.llvm.org/D51297 Files: clang-tools-extra/docs/clangd-vim.rst clang-tools-ext