This revision was automatically updated to reflect the committed changes.
Closed by commit rL348930: [CUDA][OPENMP][NVPTX]Improve logic of the debug info
support. (authored by ABataev, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
echristo accepted this revision.
echristo added a comment.
LGTM. I'm quite a bit happier with this now. Thanks for going through the back
and forth.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D51554/new/
https://reviews.llvm.org/D51554
ABataev updated this revision to Diff 176993.
ABataev marked an inline comment as done.
ABataev added a comment.
Reworked according to the latest comments from Eric.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D51554/new/
https://reviews.llvm.org/D51554
Files:
ABataev marked 4 inline comments as done.
ABataev added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:282-285
enum DebugInfoKind {
- NoDebug, /// No debug info.
- LineTableOnly, /// Line tables only.
- FullDebug /// Full debug info.
+ NoDebug,
echristo added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:282-285
enum DebugInfoKind {
- NoDebug, /// No debug info.
- LineTableOnly, /// Line tables only.
- FullDebug /// Full debug info.
+ NoDebug, /// No debug info.
+
ABataev added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:292
+ bool IsDebugEnabled = !A || A->getOption().matches(options::OPT_O0) ||
+Args.hasFlag(options::OPT_cuda_noopt_device_debug,
+
echristo added a comment.
The llvm backend patch here has discussion around debug info kinds that we
should iron out first.
Comment at: lib/Driver/ToolChains/Cuda.cpp:292
+ bool IsDebugEnabled = !A || A->getOption().matches(options::OPT_O0) ||
+
ABataev updated this revision to Diff 172003.
ABataev added a comment.
Updated processing of the debug options. -g1 (line-tables) is considered as the
regular debug directive, which may emit some useful debug info.
Repository:
rC Clang
https://reviews.llvm.org/D51554
Files:
ABataev added a comment.
Ping!
Repository:
rC Clang
https://reviews.llvm.org/D51554
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev added a comment.
In https://reviews.llvm.org/D51554#1224049, @echristo wrote:
> The change in name here from "line tables" to "directives only" feels a bit
> confusing. "Limited" seems to be a bit more clear, or even remaining line
> tables only. Can you explain where you were going
dblaikie added a comment.
In https://reviews.llvm.org/D51554#1224049, @echristo wrote:
> The change in name here from "line tables" to "directives only" feels a bit
> confusing. "Limited" seems to be a bit more clear, or even remaining line
> tables only. Can you explain where you were going
echristo added a reviewer: dblaikie.
echristo added a comment.
The change in name here from "line tables" to "directives only" feels a bit
confusing. "Limited" seems to be a bit more clear, or even remaining line
tables only. Can you explain where you were going with this particular set of
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
Nice. So, in effect, for optimized builds we'll generate pre-DWARF line info
only, unless --cuda-noopt-device-debug is specified.
Will this deal with the warnings about back-end being unable to
ABataev created this revision.
ABataev added reviewers: tra, echristo.
Herald added subscribers: JDevlieghere, guansong, aprantl.
Added support for the -gline-directives-only option + fixed logic of the
debug info for CUDA devices. If optimization level is O0, then options
14 matches
Mail list logo
