[PATCH] D51868: [libcxx] Build and test fixes for Windows

xbolva00 added a comment. Libc++ fs works on Windows now? https://reviews.llvm.org/D51868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51868: [libcxx] Build and test fixes for Windows

hamzasood added inline comments. Comment at: CMakeLists.txt:550 +endif() add_compile_flags_if_supported( +-Wextra -W -Wwrite-strings EricWF wrote: > Couldn't we keep the "-Wall" here? And just add something else that adds > "/W4"? > > Also, we don't yet

[PATCH] D51868: [libcxx] Build and test fixes for Windows

EricWF requested changes to this revision. EricWF added inline comments. This revision now requires changes to proceed. Comment at: CMakeLists.txt:550 +endif() add_compile_flags_if_supported( +-Wextra -W -Wwrite-strings Couldn't we keep the "-Wall" here?

[PATCH] D51868: [libcxx] Build and test fixes for Windows

hamzasood added inline comments. Comment at: test/support/verbose_assert.h:26 static_assert(ST == -1, "specialization required for ST != -1"); static void Print(Tp const&) { std::clog << "Value Not Streamable!\n"; } }; mclow.lists wrote: > > The renaming

[PATCH] D51868: [libcxx] Build and test fixes for Windows

mclow.lists added inline comments. Comment at: test/support/verbose_assert.h:26 static_assert(ST == -1, "specialization required for ST != -1"); static void Print(Tp const&) { std::clog << "Value Not Streamable!\n"; } }; > The renaming is to clarify that

[PATCH] D51868: [libcxx] Build and test fixes for Windows

hamzasood added inline comments. Comment at: include/filesystem:1396 - _LIBCPP_FUNC_VIS void __create_what(int __num_paths); compnerd wrote: > This possibly changes the meaning on other targets. What was the error that > this triggered? I've re-uploaded

[PATCH] D51868: [libcxx] Build and test fixes for Windows

hamzasood updated this revision to Diff 166124. hamzasood added a comment. Herald added a subscriber: christof. I've added a fix for another related issue: the tests would fail to link if libc++ is built only as a DLL. The auto-linking doesn't look for a dynamic library unless `_DLL` is defined

[PATCH] D51868: [libcxx] Build and test fixes for Windows

STL_MSFT added inline comments. Comment at: test/support/test_macros.h:147 -# elif defined(_WIN32) -#if defined(_MSC_VER) && !defined(__MINGW32__) -# define TEST_HAS_C11_FEATURES // Using Microsoft's C Runtime library compnerd wrote: > I think that the

[PATCH] D51868: [libcxx] Build and test fixes for Windows

mclow.lists added inline comments. Comment at: test/support/verbose_assert.h:24 : (IsStreamable::value ? 2 : -1))> -struct SelectStream { +struct SelectErrStream { static_assert(ST == -1, "specialization required for ST != -1"); Why the renaming

[PATCH] D51868: [libcxx] Build and test fixes for Windows

compnerd added inline comments. Herald added a subscriber: libcxx-commits. Comment at: include/filesystem:1396 - _LIBCPP_FUNC_VIS void __create_what(int __num_paths); This possibly changes the meaning on other targets. What was the error that this

[PATCH] D51868: [libcxx] Build and test fixes for Windows

hamzasood created this revision. hamzasood added reviewers: rnk, EricWF, compnerd, smeenai. Herald added subscribers: cfe-commits, ldionne, mgorny. The patch fixes a few issues that arise when using libc++ on Windows. Specifically: 1. The CMake configuration added `-Wall` to the compilation,