[PATCH] D51917: [CodeCompletion] Enable signature help when initializing class/struct/union members.

This revision was automatically updated to reflect the committed changes. Closed by commit rC341949: [CodeCompletion] Enable signature help when initializing class/struct/union… (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D51917?vs=164866&id=164883#t

[PATCH] D51917: [CodeCompletion] Enable signature help when initializing class/struct/union members.

This revision was automatically updated to reflect the committed changes. Closed by commit rL341949: [CodeCompletion] Enable signature help when initializing class/struct/union… (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.

[PATCH] D51917: [CodeCompletion] Enable signature help when initializing class/struct/union members.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the fix! Repository: rC Clang https://reviews.llvm.org/D51917 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D51917: [CodeCompletion] Enable signature help when initializing class/struct/union members.

kadircet updated this revision to Diff 164866. kadircet added a comment. - Update tests. Repository: rC Clang https://reviews.llvm.org/D51917 Files: include/clang/Sema/Sema.h lib/Parse/ParseDeclCXX.cpp lib/Sema/SemaCodeComplete.cpp lib/Sema/SemaDeclCXX.cpp test/CodeCompletion/ctor-

[PATCH] D51917: [CodeCompletion] Enable signature help when initializing class/struct/union members.

kadircet updated this revision to Diff 164864. kadircet marked 3 inline comments as done. kadircet added a comment. - Resolve discussions. Repository: rC Clang https://reviews.llvm.org/D51917 Files: include/clang/Sema/Sema.h lib/Parse/ParseDeclCXX.cpp lib/Sema/SemaCodeComplete.cpp li

[PATCH] D51917: [CodeCompletion] Enable signature help when initializing class/struct/union members.

ilya-biryukov added inline comments. Comment at: include/clang/Sema/Sema.h:4571 + /// Tries to get decleration for a member field. + ValueDecl *tryLookupCtorInitMemberDecl(CXXRecordDecl *ClassDecl, s/decleration/declaration. Maybe even remove the comment? th

[PATCH] D51917: [CodeCompletion] Enable signature help when initializing class/struct/union members.

ilya-biryukov added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:3472 +ParseExpressionList(ArgExprs, CommaLocs, [&] { + if (CalledSignatureHelp) +return; Let's always call signature help and code completion here to be consi

[PATCH] D51917: [CodeCompletion] Enable signature help when initializing class/struct/union members.

kadircet updated this revision to Diff 164844. kadircet marked 3 inline comments as done. kadircet added a comment. - Move ValueDecl extraction to a helper. - Call completion handlers as well. Repository: rC Clang https://reviews.llvm.org/D51917 Files: include/clang/Sema/Sema.h lib/Parse

[PATCH] D51917: [CodeCompletion] Enable signature help when initializing class/struct/union members.

ilya-biryukov added inline comments. Comment at: include/clang/Sema/Sema.h:10798 +ValueDecl *tryGetMember(CXXRecordDecl *ClassDecl, CXXScopeSpec &SS, +ParsedType TemplateTypeTy, The name is very generic, but the helper is only applicable

[PATCH] D51917: [CodeCompletion] Enable signature help when initializing class/struct/union members.

kadircet created this revision. kadircet added reviewers: sammccall, ilya-biryukov, ioeric. Herald added a subscriber: cfe-commits. Factors out member decleration gathering and uses it in parsing to call signature help. Doesn't support signature help for base class constructors, the code was too