[PATCH] D52036: [Analyzer] Use diff_plist in tests, NFC

2018-09-17 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL342365: [Analyzer] Define and use diff_plist in tests, NFC (authored by miyuki, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D52036: [Analyzer] Use diff_plist in tests, NFC

2018-09-17 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC342365: [Analyzer] Define and use diff_plist in tests, NFC (authored by miyuki, committed by ). Changed prior to commit: https://reviews.llvm.org/D52036?vs=165469=165732#toc Repository: rC Clang

[PATCH] D52036: [Analyzer] Use diff_plist in tests, NFC

2018-09-14 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. Thanks! A substitution would probably need to be defined in a different file though. https://reviews.llvm.org/D52036 ___

[PATCH] D52036: [Analyzer] Use diff_plist in tests, NFC

2018-09-14 Thread Umann Kristóf via Phabricator via cfe-commits
Szelethus added a comment. Cool! Looks a lot cleaner. https://reviews.llvm.org/D52036 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52036: [Analyzer] Use diff_plist in tests, NFC

2018-09-14 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 165469. miyuki retitled this revision from "[Analyzer] Make plist tests less fragile" to "[Analyzer] Use diff_plist in tests, NFC". miyuki edited the summary of this revision. miyuki added a comment. Use a different approach (suggested by Artem).