[PATCH] D52252: Driver: render arguments for the embedded bitcode correctly

2018-09-24 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd closed this revision. compnerd added a comment. SVN r342929 (with tests) Repository: rC Clang https://reviews.llvm.org/D52252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52252: Driver: render arguments for the embedded bitcode correctly

2018-09-24 Thread Steven Wu via Phabricator via cfe-commits
steven_wu added a comment. Thanks for doing this! Can you add some test cases just to be complete? Other than that, LGTM! Repository: rC Clang https://reviews.llvm.org/D52252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52252: Driver: render arguments for the embedded bitcode correctly

2018-09-18 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd created this revision. compnerd added a reviewer: steven_wu. When embedding bitcode, only a subset of the arguments should be recorded into the bitcode compilation command line. The frontend job is split into two jobs, one which will generate the bitcode. Ensure that the arguments for