[PATCH] D52664: Update CMakeLists.txt snippet so that example compiles
This revision was automatically updated to reflect the committed changes. Closed by commit rC343530: Update CMakeLists.txt snippet so that example compiles (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D52664?vs=167521&id=167816#toc Repository: rC Clang https://reviews.llvm.org/D52664 Files: docs/LibASTMatchersTutorial.rst Index: docs/LibASTMatchersTutorial.rst === --- docs/LibASTMatchersTutorial.rst +++ docs/LibASTMatchersTutorial.rst @@ -113,6 +113,7 @@ LoopConvert.cpp ) target_link_libraries(loop-convert +PRIVATE clangTooling clangBasic clangASTMatchers Index: docs/LibASTMatchersTutorial.rst === --- docs/LibASTMatchersTutorial.rst +++ docs/LibASTMatchersTutorial.rst @@ -113,6 +113,7 @@ LoopConvert.cpp ) target_link_libraries(loop-convert +PRIVATE clangTooling clangBasic clangASTMatchers ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D52664: Update CMakeLists.txt snippet so that example compiles
steveire added a comment. Done! Thanks for the contribution! Repository: rC Clang https://reviews.llvm.org/D52664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D52664: Update CMakeLists.txt snippet so that example compiles
danzimm added a comment. @steveire can you land this for me? I don't have commit access Repository: rC Clang https://reviews.llvm.org/D52664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D52664: Update CMakeLists.txt snippet so that example compiles
smeenai added a comment. Yep, that's my doing (https://reviews.llvm.org/rL319840). I didn't think about the documentation, whoops. Repository: rC Clang https://reviews.llvm.org/D52664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D52664: Update CMakeLists.txt snippet so that example compiles
steveire accepted this revision. steveire added a comment. This revision is now accepted and ready to land. Yes, `add_llvm_executable` uses `target_link_libraries` with `PRIVATE` for `LLVM_PTHREAD_LIB`. It is designed so that if you use the `PUBLIC|PRIVATE|INTERFACE` keyword with a target once, you have to do it at each location. Repository: rC Clang https://reviews.llvm.org/D52664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D52664: Update CMakeLists.txt snippet so that example compiles
danzimm created this revision. danzimm added a reviewer: modocache. Herald added a subscriber: cfe-commits. Previous to this the example didn't work out of the box, it seems some cmake config changed between when this was written and now. Repository: rC Clang https://reviews.llvm.org/D52664 Files: docs/LibASTMatchersTutorial.rst Index: docs/LibASTMatchersTutorial.rst === --- docs/LibASTMatchersTutorial.rst +++ docs/LibASTMatchersTutorial.rst @@ -113,6 +113,7 @@ LoopConvert.cpp ) target_link_libraries(loop-convert +PRIVATE clangTooling clangBasic clangASTMatchers Index: docs/LibASTMatchersTutorial.rst === --- docs/LibASTMatchersTutorial.rst +++ docs/LibASTMatchersTutorial.rst @@ -113,6 +113,7 @@ LoopConvert.cpp ) target_link_libraries(loop-convert +PRIVATE clangTooling clangBasic clangASTMatchers ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
