This revision was automatically updated to reflect the committed changes.
Closed by commit rL343791: [clang-tidy] NFC use CHECK-NOTES in tests for
performance-move-constructor-init (authored by JonasToth, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE343791: [clang-tidy] NFC use CHECK-NOTES in tests for
performance-move-constructor-init (authored by JonasToth, committed by ).
Changed prior to commit:
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thanks
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52691
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
JonasToth added inline comments.
Comment at: test/clang-tidy/check_clang_tidy.py:172
'-check-prefix=' + check_notes_prefix,
- '-implicit-check-not={{note|warning|error}}:'],
+ '-implicit-check-not=warning|error}}:|note: (?!FIX-IT)}}'],
JonasToth updated this revision to Diff 167934.
JonasToth marked 2 inline comments as done.
JonasToth added a comment.
- finally remove spurious change
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52691
Files:
test/clang-tidy/check_clang_tidy.py
JonasToth updated this revision to Diff 167933.
JonasToth added a comment.
-note remove spurious reordering
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52691
Files:
test/clang-tidy/check_clang_tidy.py
test/clang-tidy/performance-move-constructor-init.cpp
Index:
JonasToth updated this revision to Diff 167932.
JonasToth added a comment.
- filter with builtin python before passing to FileCheck
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52691
Files:
test/clang-tidy/check_clang_tidy.py
lebedev.ri added inline comments.
Comment at: test/clang-tidy/check_clang_tidy.py:172
'-check-prefix=' + check_notes_prefix,
- '-implicit-check-not={{note|warning|error}}:'],
+ '-implicit-check-not=warning|error}}:|note: (?!FIX-IT)}}'],
JonasToth updated this revision to Diff 167918.
JonasToth added a comment.
- fix spurious change
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52691
Files:
test/clang-tidy/check_clang_tidy.py
test/clang-tidy/performance-move-constructor-init.cpp
Index:
JonasToth marked 2 inline comments as done.
JonasToth added a comment.
check_clang_tidy now ignores `note: FIX-IT`, so only diagnostics directly
emitted from the check are tested
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52691
JonasToth updated this revision to Diff 167917.
JonasToth added a comment.
- adjust regex in check_clang_tidy
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52691
Files:
test/clang-tidy/check_clang_tidy.py
test/clang-tidy/performance-move-constructor-init.cpp
Index:
JonasToth added inline comments.
Comment at: test/clang-tidy/performance-move-constructor-init.cpp:115-117
+ // CHECK-NOTES: 7:1: note: FIX-IT applied suggested code changes
+ // CHECK-NOTES: 113:28: note: FIX-IT applied suggested code changes
+ // CHECK-NOTES: 113:29: note:
alexfh added inline comments.
Comment at: test/clang-tidy/performance-move-constructor-init.cpp:115-117
+ // CHECK-NOTES: 7:1: note: FIX-IT applied suggested code changes
+ // CHECK-NOTES: 113:28: note: FIX-IT applied suggested code changes
+ // CHECK-NOTES: 113:29: note:
JonasToth created this revision.
JonasToth added reviewers: alexfh, aaron.ballman, hokein.
Herald added subscribers: cfe-commits, xazax.hun.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52691
Files:
test/clang-tidy/performance-move-constructor-init.cpp
Index:
14 matches
Mail list logo