[PATCH] D52905: CSA: fix accessing GDM data from shared libraries

2018-10-09 Thread Joe Ranieri via Phabricator via cfe-commits
jranieri-grammatech added a comment. In https://reviews.llvm.org/D52905#1257040, @NoQ wrote: > Hmmm, interesting. A checker doesn't usually need to access these specific > static locals, at least not directly. These are usually accessed through > functions in .cpp files that are supposed to be

[PATCH] D52905: CSA: fix accessing GDM data from shared libraries

2018-10-05 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added subscribers: george.karpenkov, dcoughlin, NoQ. NoQ added a comment. Hmmm, interesting. A checker doesn't usually need to access these specific static locals, at least not directly. These are usually accessed through functions in .cpp files that are supposed to be compiled with a

[PATCH] D52905: CSA: fix accessing GDM data from shared libraries

2018-10-04 Thread Joe Ranieri via Phabricator via cfe-commits
jranieri-grammatech created this revision. Herald added subscribers: cfe-commits, mgorny. The `GDMIndex` functions return a pointer that's used as a key for looking up data, but addresses of local statics defined in header files aren't the same across shared library boundaries and the result is