smeenai added a comment.
I tried committing this for you, but it doesn't apply to master. Could you
rebase?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D52956/new/
https://reviews.llvm.org/D52956
___
cfe-commits
smeenai added a comment.
You should ask the reviewers to commit it in your behalf. You can request
commit access after you've had a few patches accepted and committed.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D52956/new/
https://reviews.llvm.org/D52956
andrewjcg added a comment.
Herald added a project: clang.
Sorry for the delay here, but this should be ready to go.
As this is my first accepted diff to LLVM, should I follow
https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access to get
commit access, or is there some other process
rsmith added a comment.
Is this change blocked on something?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D52956/new/
https://reviews.llvm.org/D52956
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
elsteveogrande accepted this revision.
elsteveogrande added a comment.
This revision is now accepted and ready to land.
lgtm!
Repository:
rC Clang
https://reviews.llvm.org/D52956
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
andrewjcg created this revision.
Herald added subscribers: cfe-commits, eraman.
Undoes `-fvisibility-inlines-hidden`.
Test Plan: added test
Repository:
rC Clang
https://reviews.llvm.org/D52956
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains/Clang.cpp
