[PATCH] D52976: [clangd] Update the out-of-date yaml-symbol-file flag in clangd.

2018-10-08 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL343963: [clangd] Update the out-of-date yaml-symbol-file flag in clangd. (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D52976: [clangd] Update the out-of-date yaml-symbol-file flag in clangd.

2018-10-08 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 168639. hokein added a comment. address comment. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52976 Files: clangd/tool/ClangdMain.cpp Index: clangd/tool/ClangdMain.cpp

[PATCH] D52976: [clangd] Update the out-of-date yaml-symbol-file flag in clangd.

2018-10-08 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. In https://reviews.llvm.org/D52976#1257614, @sammccall wrote: > Hmm, I wonder if we should remove "experimental" text and the hidden bit. Or > wait to see if we want to move to automatic index entirely? Our plan seems unclear at the moment, so I would suggest not doing

[PATCH] D52976: [clangd] Update the out-of-date yaml-symbol-file flag in clangd.

2018-10-08 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Hmm, I wonder if we should remove "experimental" text and the hidden bit. Or wait to see if we want to move to automatic index entirely? May want to mention "must have been created by a

[PATCH] D52976: [clangd] Update the out-of-date yaml-symbol-file flag in clangd.

2018-10-08 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. The flag is stale due to the recent changes of clangd indexer, this patch rename it to "index-file". Repository: rCTE Clang Tools Extra