nickdesaulniers marked an inline comment as done.
nickdesaulniers added inline comments.
Comment at: cfe/trunk/lib/Driver/Driver.cpp:81-85
+#include
#include
#if LLVM_ON_UNIX
#include // getpid
#endif
nickdesaulniers wrote:
> @rnk || @majnemer thoughts on
nickdesaulniers added inline comments.
Comment at: cfe/trunk/lib/Driver/Driver.cpp:81-85
+#include
#include
#if LLVM_ON_UNIX
#include // getpid
#endif
@rnk || @majnemer thoughts on making this:
```
#if LLVM_ON_UNIX
#include // getpid
#include // EX_IOE
nickdesaulniers added a comment.
@rnk has reverted this due to breaking the windows build (sysexits.h) is not
available there.
Repository:
rL LLVM
https://reviews.llvm.org/D53001
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344375: [Driver] check for exit code from SIGPIPE (authored
by nickdesaulniers, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D53001
Files:
cf
jfb accepted this revision.
jfb added a comment.
This revision is now accepted and ready to land.
Digging through `tools/driver/driver.cpp` this seems to be the right thing.
Maybe leave it open for a bit so others can chime in (if say they have other
drivers or whatever?). Thanks for fixing!
R
nickdesaulniers updated this revision to Diff 168733.
nickdesaulniers added a comment.
- return error code 74 (EX_IOERR) if observed
Repository:
rC Clang
https://reviews.llvm.org/D53001
Files:
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
nickdesaulniers updated this revision to Diff 168728.
nickdesaulniers added a comment.
- prefer EX_IOERR from sysexits.h
Repository:
rC Clang
https://reviews.llvm.org/D53001
Files:
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
jfb added a comment.
Just to be sure: what's the exit code from the driver? If we don't diagnose I'm
fine with it... but the exit code still needs to reflect the failure!
Repository:
rC Clang
https://reviews.llvm.org/D53001
___
cfe-commits maili
jfb added inline comments.
Comment at: lib/Driver/Driver.cpp:1406
+// for SIGPIPE. Do not print diagnostics for this case.
+if (Res == 71)
+ continue;
nickdesaulniers wrote:
> jfb wrote:
> > jfb wrote:
> > > Ditto on magical number in a header.
> > I
nickdesaulniers added inline comments.
Comment at: lib/Driver/Driver.cpp:1406
+// for SIGPIPE. Do not print diagnostics for this case.
+if (Res == 71)
+ continue;
jfb wrote:
> jfb wrote:
> > Ditto on magical number in a header.
> I think you want to
jfb added a comment.
What's the return code of the driver when the pipe is broken that way?
Comment at: lib/Driver/Driver.cpp:1406
+// for SIGPIPE. Do not print diagnostics for this case.
+if (Res == 71)
+ continue;
Ditto on magical number in a hea
nickdesaulniers created this revision.
nickdesaulniers added a reviewer: jfb.
Herald added a subscriber: cfe-commits.
https://reviews.llvm.org/D53000 adds a special exit code for SIGPIPE (writing
to a closed
reader), and rather than print a fatal warning, skips printing the
error.
Fixes PR25349,
12 matches
Mail list logo
