[PATCH] D53072: [clang-format] Create a new tool for IDEs based on clang-format

yvvan updated this revision to Diff 199151. yvvan added a comment. Some misleading reformatting fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53072/new/ https://reviews.llvm.org/D53072 Files: clang/include/clang/Format/Format.h clang/lib/Format/ContinuationIndenter.cpp

[PATCH] D53072: [clang-format] Create a new tool for IDEs based on clang-format

yvvan updated this revision to Diff 199150. yvvan added a comment. Sorry for unrelated formatting changes - that's clang-format's work :) I've removed the extra executable. I don't know how to force that behavior only for the given line (for that I need someone who can help) but in our usecase

[PATCH] D53072: [clang-format] Create a new tool for IDEs based on clang-format

yvvan added a comment. @sammccall I can't avoid adding extra formatting options because my first attempt to introduce an ordinary clang-format option faced resistance because of not fitting the clang-format purpose to format files. CHANGES SINCE LAST ACTION

[PATCH] D53072: [clang-format] Create a new tool for IDEs based on clang-format

yvvan added a comment. In D53072#1496317 , @sammccall wrote: > My feedback would be: > > - I definitely think more control over preserving line breaks would be > useful. Actually preserving *blank* lines is an important property. If you > see D60605

[PATCH] D53072: [clang-format] Create a new tool for IDEs based on clang-format

sammccall added a comment. My feedback would be: - I definitely think more control over preserving line breaks would be useful. Actually preserving *blank* lines is an important property. If you see D60605 , there are a lot of cases where clang-format wants to

[PATCH] D53072: [clang-format] Create a new tool for IDEs based on clang-format

yvvan added a comment. @ilya-biryukov I don't really care how it's used from the tool side. I'm also fine to have a new option in clang-format itself. That's why this review is here - to ask for opinions. It's easy to remove that "ide" part from this patch and just add an option for

[PATCH] D53072: [clang-format] Create a new tool for IDEs based on clang-format

ilya-biryukov added a comment. In D53072#1478575 , @yvvan wrote: > @sammccall > > Having a separate tool is nice because it allows the client to make it > plugable. clang-format sometimes changes options quite significantly and it > can be nice if you

[PATCH] D53072: [clang-format] Create a new tool for IDEs based on clang-format

yvvan added a comment. @sammccall Having a separate tool is nice because it allows the client to make it plugable. clang-format sometimes changes options quite significantly and it can be nice if you have a choice which version to pick, otherwise it might be unable to read the configuration

[PATCH] D53072: [clang-format] Create a new tool for IDEs based on clang-format

sammccall added a comment. You may be interested in D60605 , which is a related idea (adding incremental format-and-indent-on-type to clangd). These are opposite extremes in some sense: this patch integrates deeply into clang-format and that patch entirely

[PATCH] D53072: [clang-format] Create a new tool for IDEs based on clang-format

yvvan updated this revision to Diff 194844. yvvan retitled this revision from "[clang-format] Introduce the flag which allows not to shrink lines" to "[clang-format] Create a new tool for IDEs based on clang-format". yvvan edited the summary of this revision. yvvan added a reviewer: arphaman.