[PATCH] D53076: [analyzer] ConditionBRVisitor: Enhance to write out more information

NoQ accepted this revision. NoQ added a comment. Yay!! I'm happy with this change and redirected all my wrath on its dependencies. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53076/new/ https://reviews.llvm.org/D53076 ___ cfe-commits mai

[PATCH] D53076: [analyzer] ConditionBRVisitor: Enhance to write out more information

Charusso added a comment. Thanks you @NoQ for the great idea! Without the duplicated `BugReport.cpp` reports it could be an on-by-default patch, see: Before: F8685549: before.html After: F8685550: after.html It is not per

[PATCH] D53076: [analyzer] ConditionBRVisitor: enhance to write out more information

NoQ added a comment. Instead of having those as events similar to "Assuming", we could turn the new "Knowing" pieces into floating pop-ups - imagine you hover the mouse over a condition `foo()` and it says "`foo()` is false". That is, instead of `PathDiagnosticsEventPiece`, a new kind of piece

[PATCH] D53076: [analyzer] ConditionBRVisitor: enhance to write out more information

NoQ added a comment. Btw, did you try running this patch against big projects? 'Cause it's a high-impact change and we'd have to be careful with it. I ran it on LLVM real quick and noticed that 97.3% (!) of reports contained at least one of the new notes, with number of HTML path pieces increas