[PATCH] D53212: inhereit LLVM_ENABLE_LIBXML2

2018-11-29 Thread David Callahan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL347870: inhereit LLVM_ENABLE_LIBXML2 (authored by david2050, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D53212: inhereit LLVM_ENABLE_LIBXML2

2018-11-05 Thread Brian Gesiak via Phabricator via cfe-commits
modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Sorry to have let this languish! LGTM. Repository: rC Clang https://reviews.llvm.org/D53212 ___ cfe-commits mailing list

[PATCH] D53212: inhereit LLVM_ENABLE_LIBXML2

2018-10-12 Thread David Callahan via Phabricator via cfe-commits
david2050 updated this revision to Diff 169482. david2050 added a comment. fix typo Repository: rC Clang https://reviews.llvm.org/D53212 Files: CMakeLists.txt Index: CMakeLists.txt === --- CMakeLists.txt +++ CMakeLists.txt

[PATCH] D53212: inhereit LLVM_ENABLE_LIBXML2

2018-10-12 Thread Michał Górny via Phabricator via cfe-commits
mgorny added inline comments. Comment at: CMakeLists.txt:92 option(CLANG_ENABLE_BOOTSTRAP "Generate the clang bootstrap target" OFF) + option(LLVM_ENABLE_LIBXM2 "Use libxml2 if available." ON) I suppose it will work better without typos. Repository: rC

[PATCH] D53212: inhereit LLVM_ENABLE_LIBXML2

2018-10-12 Thread David Callahan via Phabricator via cfe-commits
david2050 created this revision. Herald added subscribers: cfe-commits, mgorny. When building in an LLVM context, we should respect its LLVM_ENABLE_LIBXML2 option. Repository: rC Clang https://reviews.llvm.org/D53212 Files: CMakeLists.txt Index: CMakeLists.txt