ioeric abandoned this revision.
ioeric marked an inline comment as done.
ioeric added inline comments.
Comment at: clangd/CodeComplete.cpp:563
for (auto *Context : CCContext.getVisitedContexts()) {
- if (isa(Context))
+ if (isa(Context)) {
ioeric planned changes to this revision.
ioeric added a comment.
I got the behavior of `printNamespaceScope` wrong in this patch. Will update.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53926
___
cfe-commits mailing list
ioeric updated this revision to Diff 171928.
ioeric added a comment.
- revert wrong comment
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53926
Files:
clangd/AST.h
clangd/CodeComplete.cpp
unittests/clangd/CodeCompleteTests.cpp
Index:
ioeric updated this revision to Diff 171924.
ioeric added a comment.
- Clarify documentation for printNamespaceScope
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53926
Files:
clangd/AST.h
clangd/CodeComplete.cpp
unittests/clangd/CodeCompleteTests.cpp
Index:
ilya-biryukov added inline comments.
Comment at: clangd/CodeComplete.cpp:563
for (auto *Context : CCContext.getVisitedContexts()) {
- if (isa(Context))
+ if (isa(Context)) {
Info.AccessibleScopes.push_back(""); // global namespace
ioeric
ioeric added inline comments.
Comment at: clangd/CodeComplete.cpp:563
for (auto *Context : CCContext.getVisitedContexts()) {
- if (isa(Context))
+ if (isa(Context)) {
Info.AccessibleScopes.push_back(""); // global namespace
ilya-biryukov
ilya-biryukov added inline comments.
Comment at: clangd/CodeComplete.cpp:563
for (auto *Context : CCContext.getVisitedContexts()) {
- if (isa(Context))
+ if (isa(Context)) {
Info.AccessibleScopes.push_back(""); // global namespace
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
This avoids duplicated scopes in the query e.g. when anonymous namespace
is present.
Repository:
rCTE Clang Tools Extra
