This revision was automatically updated to reflect the committed changes.
Closed by commit rL346680: [analyzer] Drastically simplify the tblgen files
used for checkers (authored by Szelethus, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Szelethus added a comment.
> I agree that it's aesthetically satisfying, but it is (1) inconvenient to
> write because that's the whole new syntax you need to memorize, i.e. all
> those <> and semicolons and (2) not cooperating when i want to look up
> checker name by source file (have to scan
NoQ accepted this revision.
NoQ added a comment.
Thx!! Burn it.
> tblgen files look awesome. I get that this isn't a very strong point, but
> it's a pretty sight compared to a .def file.
I agree that it's aesthetically satisfying, but it is (1) inconvenient to write
because that's the whole
Szelethus added a comment.
Ping
Repository:
rC Clang
https://reviews.llvm.org/D53995
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Szelethus updated this revision to Diff 172534.
https://reviews.llvm.org/D53995
Files:
include/clang/Driver/CC1Options.td
include/clang/StaticAnalyzer/Checkers/CheckerBase.td
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/ClangCheckers.cpp
Szelethus updated this revision to Diff 172533.
Szelethus added a comment.
- Came to the shocking realization that `Hidden` is also an unused property, so
I removed that too.
- Added comments to `CheckerBase.td`.
- Added missing ` // end "packagename"` comments
Now that `CheckerBase.td` isn't
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
LGTM, but let's wait for @NoQ before committing.
Repository:
rC Clang
https://reviews.llvm.org/D53995
___
cfe-commits mailing list
Szelethus created this revision.
Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, MTC.
Herald added subscribers: cfe-commits, dkrupp, donat.nagy, jfb,
mikhail.ramalho, a.sidorin, rnkovacs, szepet, whisperity.
TL;DR: Interestingly, only about the quarter of the emitter file is used,
