[PATCH] D54013: [analyzer] NFC: MallocChecker: Avoid redundant transitions.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2383-2384 + if (RS == OldRS) +return; + NoQ wrote: > Szelethus wrote: > > Hmmm, I guess we return here because if `RegionState` is

[PATCH] D54013: [analyzer] NFC: MallocChecker: Avoid redundant transitions.

This revision was automatically updated to reflect the committed changes. Closed by commit rC347955: [analyzer] MallocChecker: Avoid redundant transitions. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D54013?vs=172629=176030#toc Repository: rC

[PATCH] D54013: [analyzer] NFC: MallocChecker: Avoid redundant transitions.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2383-2384 + if (RS == OldRS) +return; + Szelethus wrote: > Hmmm, I guess we return here because if `RegionState` is unchanged, so should > be `ReallocPairs` and

[PATCH] D54013: [analyzer] NFC: MallocChecker: Avoid redundant transitions.

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2383-2384 + if (RS == OldRS) +return; + Hmmm, I guess we return here because if `RegionState` is unchanged, so should be `ReallocPairs` and `FreeReturnValue`,

[PATCH] D54013: [analyzer] NFC: MallocChecker: Avoid redundant transitions.

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2369 ProgramStateRef state = C.getState(); - RegionStateTy RS = state->get(); + RegionStateTy OldRS = state->get(); RegionStateTy::Factory = state->get_context();

[PATCH] D54013: [analyzer] NFC: MallocChecker: Avoid redundant transitions.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2369 ProgramStateRef state = C.getState(); - RegionStateTy RS = state->get(); + RegionStateTy OldRS = state->get(); RegionStateTy::Factory = state->get_context();