ioeric added inline comments.
Comment at: clangd/index/dex/dexp/Dexp.cpp:166
+ cl::init(10),
+ cl::desc("Max results to display. This flag is only meaningful when
-name"
+ " is set."),
Maybe `The max number of symbols with the same name
hokein updated this revision to Diff 172736.
hokein added a comment.
Update based on the offline discussion.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54106
Files:
clangd/index/dex/dexp/Dexp.cpp
Index: clangd/index/dex/dexp/Dexp.cpp
hokein added inline comments.
Comment at: clangd/index/dex/dexp/Dexp.cpp:128
};
cl::opt Limit{
"limit",
ioeric wrote:
> I think we should make it configurable like what we do here.
Made it configurable for `Lookup`. `Limit` option is used to
hokein updated this revision to Diff 172598.
hokein added a comment.
Address review comment.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54106
Files:
clangd/index/dex/dexp/Dexp.cpp
Index: clangd/index/dex/dexp/Dexp.cpp
ioeric added inline comments.
Comment at: clangd/index/dex/dexp/Dexp.cpp:128
};
cl::opt Limit{
"limit",
I think we should make it configurable like what we do here.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54106
hokein created this revision.
hokein added a reviewer: ioeric.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov.
When the limit of FuzzyFindRequest is not specified, MemIndex and
DexIndex will set it MAX_UINT, which doesn't make sense in the active tool dexp
(we might
