[PATCH] D54489: Implement -frecord-command-line (-frecord-gcc-switches)

MaskRay added a comment. In D54489#1331249 , @scott.linder wrote: > rL349155 @scott.linder Hi Scott, you may have an opion on https://gcc.gnu.org/ml/gcc-patches/2020-03/msg00230.html . I also started a thread on cfe

[PATCH] D54489: Implement -frecord-command-line (-frecord-gcc-switches)

scott.linder closed this revision. scott.linder added a comment. rL349155 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54489/new/ https://reviews.llvm.org/D54489 ___ cfe-commits mailing list cfe-commits@

[PATCH] D54489: Implement -frecord-command-line (-frecord-gcc-switches)

rjmccall added a comment. In D54489#1330331 , @scott.linder wrote: > In D54489#1330255 , @rjmccall wrote: > > > So we're using the same command line option as GCC to produce something in > > the same section as GC

[PATCH] D54489: Implement -frecord-command-line (-frecord-gcc-switches)

scott.linder added a comment. In D54489#1330255 , @rjmccall wrote: > So we're using the same command line option as GCC to produce something in > the same section as GCC but formatting that section incompatibly with GCC? > That combination of choices do

[PATCH] D54489: Implement -frecord-command-line (-frecord-gcc-switches)

rjmccall added a comment. So we're using the same command line option as GCC to produce something in the same section as GCC but formatting that section incompatibly with GCC? That combination of choices does not seem like a good idea. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D544

[PATCH] D54489: Implement -frecord-command-line (-frecord-gcc-switches)

scott.linder updated this revision to Diff 178082. scott.linder added a comment. Update documentation to match section naming change, and to explicitly note that the section format differs from the equivalent GCC format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54489/new/ https://

[PATCH] D54489: Implement -frecord-command-line (-frecord-gcc-switches)

scott.linder added a comment. There may be changes to some details in the LLVM patch; once they are finalized I will update the Clang patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54489/new/ https://reviews.llvm.org/D54489 ___ cfe-c

[PATCH] D54489: Implement -frecord-command-line (-frecord-gcc-switches)

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54489/new/ https://reviews.llvm.org/D54489 ___ cfe-commits mailing list

[PATCH] D54489: Implement -frecord-command-line (-frecord-gcc-switches)

scott.linder updated this revision to Diff 175540. scott.linder added a comment. Update documentation for new option CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54489/new/ https://reviews.llvm.org/D54489 Files: docs/ClangCommandLineReference.rst include/clang/Driver/CC1Options.td

[PATCH] D54489: Implement -frecord-command-line (-frecord-gcc-switches)

rjmccall added inline comments. Comment at: docs/ClangCommandLineReference.rst:799 +command-line. Command-lines in the section are surrounded and separated by null +bytes. Spaces and backslashes in the command-line are escaped with backslashes. +(ELF Only) How ab

[PATCH] D54489: Implement -frecord-command-line (-frecord-gcc-switches)

scott.linder updated this revision to Diff 174429. scott.linder added a comment. Update documentation for new option and error in the driver when generating for unsupported object-file format. https://reviews.llvm.org/D54489 Files: docs/ClangCommandLineReference.rst include/clang/Driver/CC

[PATCH] D54489: Implement -frecord-command-line (-frecord-gcc-switches)

rjmccall added inline comments. Comment at: docs/ClangCommandLineReference.rst:797 + +Generate a section .LLVM.command.line containing the clang driver command line. + scott.linder wrote: > rjmccall wrote: > > 1. Is this section always called `.LLVM.command.line`

[PATCH] D54489: Implement -frecord-command-line (-frecord-gcc-switches)

scott.linder added a comment. Looking a bit further, it seems some other object-file formats have conventions for naming (e.g. Mach-O sections are `_snake_case`) and so `.LLVM.command.line` may not end up being what we want universally. Additionally it seems things like `.ident` are not support

[PATCH] D54489: Implement -frecord-command-line (-frecord-gcc-switches)

scott.linder added inline comments. Comment at: docs/ClangCommandLineReference.rst:797 + +Generate a section .LLVM.command.line containing the clang driver command line. + rjmccall wrote: > 1. Is this section always called `.LLVM.command.line`, or does it differ

[PATCH] D54489: Implement -frecord-command-line (-frecord-gcc-switches)

rjmccall added inline comments. Comment at: docs/ClangCommandLineReference.rst:797 + +Generate a section .LLVM.command.line containing the clang driver command line. + 1. Is this section always called `.LLVM.command.line`, or does it differ by target object-file

[PATCH] D54489: Implement -frecord-command-line (-frecord-gcc-switches)

scott.linder updated this revision to Diff 174104. scott.linder retitled this revision from "Implement -frecord-gcc-switches" to "Implement -frecord-command-line (-frecord-gcc-switches)". scott.linder added a comment. Change canonical option name to -frecord-command-line and add an alias from -f