[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

This revision was automatically updated to reflect the committed changes. Closed by commit rL348884: [analyzer][CStringChecker] evaluate explicit_bzero (authored by devnexen, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks good, thanks! Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:2216 + // In this case we just return. + if (StateZeroSize && !StateNonZeroSize) { +

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

devnexen added a comment. ping just want to put it behind :-) thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54592/new/ https://reviews.llvm.org/D54592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

devnexen updated this revision to Diff 177171. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54592/new/ https://reviews.llvm.org/D54592 Files: lib/StaticAnalyzer/Checkers/CStringChecker.cpp test/Analysis/string.c Index: test/Analysis/string.c

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

devnexen marked an inline comment as done. devnexen added inline comments. Comment at: test/Analysis/string.c:1405-1406 + clang_analyzer_eval(strlen(str) == 4); // expected-warning{{TRUE}} + bzero(str + 2, 2); + clang_analyzer_eval(strlen(str) == 0); //

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:127 void evalMemset(CheckerContext , const CallExpr *CE) const; + void evalExplicitBzero(CheckerContext , const CallExpr *CE) const; I guess let's do just `evalBzero`?

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

devnexen added a comment. In D54592#1319421 , @Szelethus wrote: > I hope you don't mind me changing the revision title -- many of us are > automatically subscribed to revisions with `analyzer` in the title, that also > helps with getting feedback sooner

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

devnexen updated this revision to Diff 176780. devnexen added a comment. - Using same type for zero as memset. - Updating slighty the unit tests with ptr/dynamic array for bzero. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54592/new/ https://reviews.llvm.org/D54592 Files:

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

devnexen marked an inline comment as done. devnexen added inline comments. Comment at: test/Analysis/string.c:1399 + bzero(str, 2); + clang_analyzer_eval(strlen(str) == 0); // expected-warning{{UNKNOWN}} +} NoQ wrote: > I suspect that the reason why this

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

Szelethus added a comment. I hope you don't mind me changing the revision title -- many of us are automatically subscribed to revisions with `analyzer` in the title, that also helps with getting feedback sooner :) Repository: rC Clang CHANGES SINCE LAST ACTION