[PATCH] D55069: Extend the CommentVisitor with parameter types

This revision was automatically updated to reflect the committed changes. Closed by commit rL348100: Extend the CommentVisitor with parameter types (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D55069: Extend the CommentVisitor with parameter types

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D55069#1314508 , @steveire wrote: > > Huh, that's surprising. It's a perfect forwarding reference > > It's not a forwarding reference

[PATCH] D55069: Extend the CommentVisitor with parameter types

steveire added a comment. > Huh, that's surprising. It's a perfect forwarding reference It's not a forwarding reference because the template parameter is from the record, not the function. See https://godbolt.org/z/L4N2aS > One of the reasons I think this may be important is with the JSON

[PATCH] D55069: Extend the CommentVisitor with parameter types

aaron.ballman added a comment. In D55069#1313591 , @steveire wrote: > The follow-up patch didn't build anymore with the `&&`. > > ../tools/clang/lib/AST/ASTDumper.cpp:2672:75: error: cannot bind rvalue > reference of type ‘const

[PATCH] D55069: Extend the CommentVisitor with parameter types

steveire added a comment. Ah, `test/Misc/ast-dump-comment.cpp` is existing test coverage for this indeed, great. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55069/new/ https://reviews.llvm.org/D55069 ___

[PATCH] D55069: Extend the CommentVisitor with parameter types

steveire added a comment. The follow-up patch didn't build anymore with the `&&`. ../tools/clang/lib/AST/ASTDumper.cpp:2672:75: error: cannot bind rvalue reference of type ‘const clang::comments::FullComment*&&’ to lvalue of type ‘const clang::comments::FullComment* const’

[PATCH] D55069: Extend the CommentVisitor with parameter types

steveire updated this revision to Diff 175962. steveire added a comment. Add && Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55069/new/ https://reviews.llvm.org/D55069 Files: include/clang/AST/CommentVisitor.h Index: include/clang/AST/CommentVisitor.h

[PATCH] D55069: Extend the CommentVisitor with parameter types

steveire updated this revision to Diff 175967. steveire added a comment. Remove && Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55069/new/ https://reviews.llvm.org/D55069 Files: include/clang/AST/CommentVisitor.h Index: include/clang/AST/CommentVisitor.h

[PATCH] D55069: Extend the CommentVisitor with parameter types

steveire added a comment. I'm not aware of existing test coverage for any of this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55069/new/ https://reviews.llvm.org/D55069 ___ cfe-commits mailing list

[PATCH] D55069: Extend the CommentVisitor with parameter types

steveire updated this revision to Diff 175960. steveire added a comment. Add && Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55069/new/ https://reviews.llvm.org/D55069 Files: include/clang/AST/CommentVisitor.h Index: include/clang/AST/CommentVisitor.h

[PATCH] D55069: Extend the CommentVisitor with parameter types

aaron.ballman added a comment. In D55069#1313276 , @aaron.ballman wrote: > Overall this seems reasonable, but this change is currently a no-op because > nothing is using this -- what's the plan for using and testing these changes? The answer is:

[PATCH] D55069: Extend the CommentVisitor with parameter types

aaron.ballman added a comment. Overall this seems reasonable, but this change is currently a no-op because nothing is using this -- what's the plan for using and testing these changes? Comment at: include/clang/AST/CommentVisitor.h:31 - RetTy Visit(PTR(Comment) C) { +

[PATCH] D55069: Extend the CommentVisitor with parameter types

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. This has precedent in the StmtVisitor. This change will make it possible to clean up the comment handling in ASTDumper. Repository: rC Clang https://reviews.llvm.org/D55069