uabelho added a comment.
Hi,
A late question about this change. I notice that this change sometimes gives me
additional DIFiles in the clang output compared to before.
E.g. if I have a file
/tmp/bar/foo.c
containing just
void foo() {
}
and I stand in /tmp/ and do
clang -emit-llvm -S -g
aprantl added a comment.
Thanks, should be fixed in r348610!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55085/new/
https://reviews.llvm.org/D55085
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
davezarzycki added a comment.
Hello @aprantl,
This change broke the test suite when building in /tmp (tmpfs) on Linux:
FAIL: Clang :: CodeGen/debug-info-abspath.c (5676 of 44360)
- TEST 'Clang :: CodeGen/debug-info-abspath.c' FAILED
Script:
---
: 'RUN: at line 1';
ilya-biryukov added a comment.
Ah, sorry, I incorrectly checked that the old revision landed without problems.
Have no data on whether the new revision breaks anything, will have to wait for
the input from the US timezone buildcop
CHANGES SINCE LAST ACTION
ilya-biryukov added a comment.
It looks like the integrate went smoothly with the new change, thanks for
fixing it!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55085/new/
https://reviews.llvm.org/D55085
___
cfe-commits mailing list
aprantl updated this revision to Diff 176677.
aprantl added a reviewer: ilya-biryukov.
aprantl added a comment.
Ilya, this updated revision should restore the original GCOV behavior both for
absolute and relative paths.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55085/new/
This revision was automatically updated to reflect the committed changes.
Closed by commit rC348154: Avoid emitting redundant or unusable directories in
DIFile metadata entries. (authored by adrian, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D55085?vs=176152=176422#toc
davide accepted this revision.
davide added a comment.
LGTM, sorry. for the delay.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55085/new/
https://reviews.llvm.org/D55085
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
probinson added inline comments.
Comment at: lib/IR/DiagnosticInfo.cpp:39
#include "llvm/Support/ScopedPrinter.h"
+#include "llvm/Support/raw_ostream.h"
#include
aprantl wrote:
> probinson wrote:
> > Do we use a case-sensitive sort of include files? I
aprantl marked an inline comment as done.
aprantl added inline comments.
Comment at: lib/IR/DiagnosticInfo.cpp:39
#include "llvm/Support/ScopedPrinter.h"
+#include "llvm/Support/raw_ostream.h"
#include
probinson wrote:
> Do we use a case-sensitive sort of
probinson added a comment.
> When building the FileCheck binary with debug info, this patch makes the
> build artifacts ~1kb smaller.
Nice!
Comment at: lib/IR/DiagnosticInfo.cpp:39
#include "llvm/Support/ScopedPrinter.h"
+#include "llvm/Support/raw_ostream.h"
#include
aprantl added a comment.
Adding a few more reviewers since I'm touching the backend diagnostics. The
backend change is supposed to be NFC, but it never hurts to have more feedback.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55085/new/
https://reviews.llvm.org/D55085
aprantl updated this revision to Diff 176152.
aprantl added a comment.
Remove debugging code accidentally left in the patch.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55085/new/
https://reviews.llvm.org/D55085
Files:
include/llvm/IR/DiagnosticInfo.h
aprantl updated this revision to Diff 176148.
aprantl added a reviewer: davide.
aprantl added a comment.
Herald added subscribers: nhaehnle, jvesely.
Turns out that my patch had an unintended interaction with the backend
diagnostics engine. This is an updated version of the patch that also
aprantl updated this revision to Diff 175982.
aprantl added a comment.
Bugfix for LexicalBlockFiles + testcase updates.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55085/new/
https://reviews.llvm.org/D55085
Files:
lib/CodeGen/CGDebugInfo.cpp
test/CodeGen/debug-info-abspath.c
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Seems OK to me
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55085/new/
https://reviews.llvm.org/D55085
___
cfe-commits mailing
aprantl created this revision.
aprantl added reviewers: dblaikie, probinson.
aprantl added a project: debug-info.
As discussed on llvm-dev today, Clang currently emits redundant directories in
DIFile entries, such as
`.file 1 "/Volumes/Data/llvm"
17 matches
Mail list logo
