[PATCH] D55307: [analyzer] MoveChecker Pt.6: Suppress the warning for the few move-safe STL classes.

RKSimon added inline comments. Herald added subscribers: steakhal, ASDenysPetrov, martong, Charusso. Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:81 + "optional", + "packaged_task" + "promise", @NoQ

[PATCH] D55307: [analyzer] MoveChecker Pt.6: Suppress the warning for the few move-safe STL classes.

This revision was automatically updated to reflect the committed changes. Closed by commit rC349191: [analyzer] MoveChecker Pt.6: Suppress the warning for the move-safe STL classes. (authored by dergachev, committed by ). Changed prior to commit:

[PATCH] D55307: [analyzer] MoveChecker Pt.6: Suppress the warning for the few move-safe STL classes.

NoQ marked 2 inline comments as done. NoQ added inline comments. Comment at: test/Analysis/Inputs/system-header-simulator-cxx.h:782 +namespace std { + template // TODO: Implement the stub for deleter. + class unique_ptr { a_sidorin wrote: > Nit: our coding

[PATCH] D55307: [analyzer] MoveChecker Pt.6: Suppress the warning for the few move-safe STL classes.

a_sidorin accepted this revision. a_sidorin added a comment. I think the change is fine, just a minor stylish remark. Comment at: test/Analysis/Inputs/system-header-simulator-cxx.h:782 +namespace std { + template // TODO: Implement the stub for deleter. + class unique_ptr {

[PATCH] D55307: [analyzer] MoveChecker Pt.6: Suppress the warning for the few move-safe STL classes.

NoQ updated this revision to Diff 177048. NoQ marked an inline comment as done. NoQ added a comment. Add one more important case: `std::optional`. When moved, it moves the object within it into the new optional, if any. So the object is left in unspecified state, but the state of the optional

[PATCH] D55307: [analyzer] MoveChecker Pt.6: Suppress the warning for the few move-safe STL classes.

NoQ added inline comments. Comment at: test/Analysis/diagnostics/explicit-suppression.cpp:22 #ifndef SUPPRESSED - // expected-warning@../Inputs/system-header-simulator-cxx.h:670 {{Called C++ object pointer is null}} + //

[PATCH] D55307: [analyzer] MoveChecker Pt.6: Suppress the warning for the few move-safe STL classes.

Szelethus added inline comments. Comment at: test/Analysis/diagnostics/explicit-suppression.cpp:22 #ifndef SUPPRESSED - // expected-warning@../Inputs/system-header-simulator-cxx.h:670 {{Called C++ object pointer is null}} + //

[PATCH] D55307: [analyzer] MoveChecker Pt.6: Suppress the warning for the few move-safe STL classes.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. AFAIK `constexpr` arrays can be `std::sort`-ed, but it probably isn't worth the effort, I tried it myself when I was working with non-checker configs, and it's a big hassle for

[PATCH] D55307: [analyzer] MoveChecker Pt.6: Suppress the warning for the few move-safe STL classes.

NoQ updated this revision to Diff 176856. NoQ marked an inline comment as done. NoQ added a comment. Convert the pointer to a reference. In D55307#1320434 , @Szelethus wrote: > > Had to pass the checker into the visitor and make some methods non-static

[PATCH] D55307: [analyzer] MoveChecker Pt.6: Suppress the warning for the few move-safe STL classes.

NoQ added inline comments. Comment at: test/Analysis/diagnostics/explicit-suppression.cpp:22 #ifndef SUPPRESSED - // expected-warning@../Inputs/system-header-simulator-cxx.h:670 {{Called C++ object pointer is null}} + //

[PATCH] D55307: [analyzer] MoveChecker Pt.6: Suppress the warning for the few move-safe STL classes.

Szelethus marked an inline comment as done. Szelethus added a comment. This looks great! > Had to pass the checker into the visitor and make some methods non-static > because globals with constructors are discouraged. How about making the set `constexpr`? Comment at:

[PATCH] D55307: [analyzer] MoveChecker Pt.6: Suppress the warning for the few move-safe STL classes.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, george.karpenkov, szepet, rnkovacs, Szelethus. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, baloghadamsoftware. List of such classes shamelessly copied from