Ywicheng updated this revision to Diff 195656.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55409/new/
https://reviews.llvm.org/D55409
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/AnonymousEnclosedAliasesCheck.cpp
aaron.ballman added inline comments.
Comment at: clang-tidy/abseil/AnonymousEnclosedAliasesCheck.cpp:41
+// to the vector containing all candidate using declarations.
+if (AnonymousNamespaceDecl) {
+ diag(MatchedUsingDecl->getLocation(),
Naysh marked an inline comment as done.
Naysh added inline comments.
Comment at: clang-tidy/abseil/AnonymousEnclosedAliasesCheck.cpp:41
+// to the vector containing all candidate using declarations.
+if (AnonymousNamespaceDecl) {
+
aaron.ballman requested changes to this revision.
aaron.ballman added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/abseil/AnonymousEnclosedAliasesCheck.cpp:32
+void AnonymousEnclosedAliasesCheck::check(const MatchFinder::MatchResult
) {
JonasToth added a comment.
Please upload with full context.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55409/new/
https://reviews.llvm.org/D55409
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Ywicheng updated this revision to Diff 177121.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55409/new/
https://reviews.llvm.org/D55409
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/AnonymousEnclosedAliasesCheck.cpp
Ywicheng updated this revision to Diff 177115.
Ywicheng added a comment.
Updated abseil-anonymous-enclosed-alises.rst and ReleaseNotes.rst
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55409/new/
https://reviews.llvm.org/D55409
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
Ywicheng created this revision.
Ywicheng added reviewers: alexfh, hokein, aaron.ballman, astrelni, EricWF,
JonasToth.
Herald added subscribers: cfe-commits, xazax.hun, mgorny.
This patch adds one check corresponding to the Unnamed Namespace section in
https://abseil.io/tips/119.
In particular,
