[PATCH] D55411: [clang-tidy] check for flagging using declarations not in the inner most namespace

2019-04-22 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tidy/abseil/SafelyScopedCheck.cpp:22 + // The target using declaration is either: + // 1. not in any namespace declaration, or + // 2. in some namespace declaration but not in the innermost layer

[PATCH] D55411: [clang-tidy] check for flagging using declarations not in the inner most namespace

2019-04-17 Thread Yucheng Wu via Phabricator via cfe-commits
Ywicheng updated this revision to Diff 195661. Ywicheng marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55411/new/ https://reviews.llvm.org/D55411 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt

[PATCH] D55411: [clang-tidy] check for flagging using declarations not in the inner most namespace

2019-04-11 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tidy/abseil/SafelyScopedCheck.cpp:37 + diag(MatchedDecl->getLocation(), + "using declaration %0 not declared in the innermost namespace.") + << MatchedDecl; You should remove the full stop at the

[PATCH] D55411: [clang-tidy] check for flagging using declarations not in the inner most namespace

2019-04-10 Thread Yucheng Wu via Phabricator via cfe-commits
Ywicheng updated this revision to Diff 194631. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55411/new/ https://reviews.llvm.org/D55411 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/SafelyScopedCheck.cpp

[PATCH] D55411: [clang-tidy] check for flagging using declarations not in the inner most namespace

2019-04-10 Thread Yucheng Wu via Phabricator via cfe-commits
Ywicheng updated this revision to Diff 194623. Ywicheng marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55411/new/ https://reviews.llvm.org/D55411 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt

[PATCH] D55411: [clang-tidy] check for flagging using declarations not in the inner most namespace

2019-04-10 Thread Yucheng Wu via Phabricator via cfe-commits
Ywicheng updated this revision to Diff 194614. Ywicheng marked an inline comment as done. Ywicheng edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55411/new/ https://reviews.llvm.org/D55411 Files: clang-tidy/abseil/AbseilTidyModule.cpp

[PATCH] D55411: [clang-tidy] check for flagging using declarations not in the inner most namespace

2018-12-10 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tidy/abseil/SafelyScopedCheck.cpp:22 + // The target using declaration is either: + // 1. not in any namespace declaration, or + // 2. in some namespace declaration but not in the innermost layer Why is

[PATCH] D55411: [clang-tidy] check for flagging using declarations not in the inner most namespace

2018-12-07 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added a comment. Please upload the patch with full context. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55411/new/ https://reviews.llvm.org/D55411 ___ cfe-commits mailing list

[PATCH] D55411: [clang-tidy] check for flagging using declarations not in the inner most namespace

2018-12-06 Thread Yucheng Wu via Phabricator via cfe-commits
Ywicheng created this revision. Ywicheng added a reviewer: JonasToth. Herald added subscribers: cfe-commits, xazax.hun, mgorny. This patch adds one check corresponding to the Scope of the Alias section in https://abseil.io/tips/119. In particular, it is better to put aliases in the innermost