[PATCH] D55544: Warning: objc-encodings-larger-than=

thakis added a comment. Herald added a subscriber: dang. FYI D96816 made clang emit way smaller encodings by default Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55544/new/ https://reviews.llvm.org/D55544

[PATCH] D55544: Warning: objc-encodings-larger-than=

ahatanak added a comment. The patch looks largely fine to me. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6207 +def warn_objc_method_encoding_too_large : Warning< + "%0 method %1 encoding of size %2 is larger than %3 bytes">, + InGroup; You can

[PATCH] D55544: Warning: objc-encodings-larger-than=

dmaclach added a comment. Akira/John/Erik - any thoughts? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55544/new/ https://reviews.llvm.org/D55544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D55544: Warning: objc-encodings-larger-than=

stephanemoore added a comment. In D55544#1326606 , @stephanemoore wrote: > FYI: > I have a clang-tidy check almost ready for review that aims to flag large > Objective-C type encodings. https://reviews.llvm.org/D55640 Repository: rC Clang

[PATCH] D55544: Warning: objc-encodings-larger-than=

dmaclach updated this revision to Diff 177746. dmaclach added a comment. Updated to fix Stephane's good catch of Objective C vs Objective-C Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55544/new/ https://reviews.llvm.org/D55544 Files: docs/ReleaseNotes.rst

[PATCH] D55544: Warning: objc-encodings-larger-than=

dmaclach updated this revision to Diff 177744. dmaclach marked an inline comment as done. dmaclach added a comment. Full Diffs as requested. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55544/new/ https://reviews.llvm.org/D55544 Files: docs/ReleaseNotes.rst

[PATCH] D55544: Warning: objc-encodings-larger-than=

arphaman added a comment. Thanks for working on this! Could you please post a patch with full context (git diff -U)? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55544/new/ https://reviews.llvm.org/D55544 ___

[PATCH] D55544: Warning: objc-encodings-larger-than=

dmaclach added a comment. In D55544#1326956 , @theraven wrote: > It would probably be a good idea to have a similar check on properties, as > property encoding strings contain the type encoding (plus extra stuff). Properties are already picked up based

[PATCH] D55544: Warning: objc-encodings-larger-than=

dmaclach updated this revision to Diff 177732. dmaclach added a comment. Added some spacing around early exit as requested by theraven. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55544/new/ https://reviews.llvm.org/D55544 Files: docs/ReleaseNotes.rst

[PATCH] D55544: Warning: objc-encodings-larger-than=

theraven added a comment. It would probably be a good idea to have a similar check on properties, as property encoding strings contain the type encoding (plus extra stuff). I wonder if we also want an option in code generation to replace very long type encodings (or encodings of specifically

[PATCH] D55544: Warning: objc-encodings-larger-than=

stephanemoore added a comment. FYI: I have a clang-tidy check almost ready for review that aims to flag large Objective-C type encodings. Comment at: include/clang/Basic/LangOptions.def:103 +BENIGN_LANGOPT(ObjCLargeEncodingSize, 32, 0, + "if non-zero, warn about

[PATCH] D55544: Warning: objc-encodings-larger-than=

dmaclach created this revision. dmaclach added a project: clang. Herald added a subscriber: cfe-commits. Issue a warning when the Objective C runtime encoding generated for an iVar, method, or block exceeds a user configurable value. Off by default. Note that handling iVars and methods will