[PATCH] D55697: [analyzer] Assume that we always have a SubEngine available

2018-12-15 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC349266: [analyzer] Assume that we always have a SubEngine available (authored by xazax, committed by ). Changed prior to commit: https://reviews.llvm.org/D55697?vs=178204=178357#toc Repository: rC

[PATCH] D55697: [analyzer] Assume that we always have a SubEngine available

2018-12-14 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D55697#1331001 , @Szelethus wrote: > We could also add an assert to getOwningEngine I guess. Or make it return a reference, like everything else. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D55697: [analyzer] Assume that we always have a SubEngine available

2018-12-14 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yup, squash these! Even if there was a plan to use `ProgramState` separately for some other sort of analysis that doesn't involve a sub-engine, it is currently long forgotten. Repository: rC

[PATCH] D55697: [analyzer] Assume that we always have a SubEngine available

2018-12-14 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. We could also add an assert to getOwningEngine I guess. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55697/new/ https://reviews.llvm.org/D55697 ___ cfe-commits mailing list

[PATCH] D55697: [analyzer] Assume that we always have a SubEngine available

2018-12-14 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun created this revision. xazax.hun added reviewers: NoQ, george.karpenkov. xazax.hun added a project: clang. Herald added subscribers: gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. I was stumbled upon some checks