[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

Eugene.Zelenko added a comment. In D56160#1769107 , @bernhardmgruber wrote: > @Eugene.Zelenko I tried to find what you refer to by PR44206, but I could not > find anything :/ Can you please provide me with a link? Thank you! See

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

bernhardmgruber added a comment. @Eugene.Zelenko I tried to find what you refer to by PR44206, but I could not find anything :/ Can you please provide me with a link? Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ https://reviews.llvm.org/D56160

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

Eugene.Zelenko added a comment. Please take a look on PR44206. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ https://reviews.llvm.org/D56160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

aaron.ballman closed this revision. aaron.ballman added a comment. In D56160#1497473 , @bernhardmgruber wrote: > - fixed formatting > - fixed function names in tests > - added `-fexceptions` to test arguments > - fixed typo in release notes Thanks! I

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

bernhardmgruber updated this revision to Diff 198937. bernhardmgruber marked 3 inline comments as done. bernhardmgruber added a comment. - fixed formatting - fixed function names in tests - added `-fexceptions` to test arguments - fixed type in release notes CHANGES SINCE LAST ACTION

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

aaron.ballman reopened this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D56160#1496594 , @aaron.ballman wrote: > In D56160#1496391 , @bernhardmgruber > wrote: > >

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

aaron.ballman added a comment. In D56160#1496391 , @bernhardmgruber wrote: > @aaron.ballman I do not have commit privileges and I would be very thankful, > if you could commit this patch for me! Thank you! I've commit for you in r360345, thank you for

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:203 + if (ContainsQualifiers + ContainsSpecifiers + ContainsSomethingElse > 1) +return {}; + bernhardmgruber wrote: > aaron.ballman wrote: > > This should

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

bernhardmgruber marked 2 inline comments as done. bernhardmgruber added a comment. @aaron.ballman I do not have commit privileges and I would be very thankful, if you could commit this patch for me! Thank you! Comment at:

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

aaron.ballman added a comment. In D56160#1495847 , @bernhardmgruber wrote: > @aaron.ballman and @JonasToth: Thank you for the patience and all the > feedback! It means a great deal to me to have a patch accepted here! You're very welcome! Do you need

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

bernhardmgruber added a comment. @aaron.ballman and @JonasToth: Thank you for the patience and all the feedback! It means a great deal to me to have a patch accepted here! Comment at: clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:95-98 +if (!S->getQualifierLoc() &&

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from a formatting issue, this LGTM, thank you! Comment at: clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:93 +DeclarationName Name =

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

bernhardmgruber updated this revision to Diff 198531. bernhardmgruber marked 8 inline comments as done. bernhardmgruber added a comment. Fixed small nits suggested by @aaron.ballman. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ https://reviews.llvm.org/D56160

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:85-87 +if (TL.getQualifierLoc()) + if (!TraverseNestedNameSpecifierLoc(TL.getQualifierLoc())) +return false; You can combine these.

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

bernhardmgruber updated this revision to Diff 198143. bernhardmgruber marked 9 inline comments as done. bernhardmgruber added a comment. It took a long while to figure out how to handle certain macro cases. Here is what I came up with: When tokenizing the source code from the beginning of the

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

bernhardmgruber added inline comments. Comment at: clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:274 + + if (F->getLocation().isInvalid()) +return; aaron.ballman wrote: > bernhardmgruber wrote: > > aaron.ballman wrote: > > > bernhardmgruber wrote: > >

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:274 + + if (F->getLocation().isInvalid()) +return; bernhardmgruber wrote: > aaron.ballman wrote: > > bernhardmgruber wrote: > > > aaron.ballman wrote: > > >

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

bernhardmgruber marked an inline comment as not done. bernhardmgruber added a comment. Thank you for the rich feedback @aaron.ballman. I found a solution which seems to work for many of my test cases. Comment at: clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:274 + + if

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

bernhardmgruber updated this revision to Diff 191233. bernhardmgruber marked 7 inline comments as done and 2 inline comments as done. bernhardmgruber added a comment. - extracting specifiers from the return type if it consists of a multitoken built-in type, and preprending it to 'auto'. -

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:180-184 + if (Info.hasMacroDefinition()) { +// The CV qualifiers of the return type are inside macros. +diag(F.getLocation(), Message); +return {}; +

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

bernhardmgruber updated this revision to Diff 189993. bernhardmgruber marked 8 inline comments as done. bernhardmgruber added a comment. - added support for __restrict - added two dots at end of comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:34 + bool VisitUnqualName(StringRef UnqualName) { +// Check for collisions with function arguments +for (ParmVarDecl *Param : F.parameters()) Missing

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

bernhardmgruber updated this revision to Diff 189222. bernhardmgruber marked 3 inline comments as done. bernhardmgruber added a comment. Fixed some little nits, thanks @JonasToth! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ https://reviews.llvm.org/D56160 Files:

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

JonasToth added a comment. From my side only the nits are left. Comment at: clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:94 + bool VisitDeclRefExpr(DeclRefExpr *S) { +const DeclarationName Name = S->getNameInfo().getName(); +if (!S->getQualifierLoc() &&

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

lebedev.ri added a comment. In D56160#1412701 , @bernhardmgruber wrote: > - renamed the check to modernize-use-trailing-return-type Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ https://reviews.llvm.org/D56160

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

bernhardmgruber added inline comments. Comment at: clang-tidy/modernize/UseTrailingReturnCheck.cpp:335 + StringRef ReturnType = tooling::fixit::getText(ReturnTypeCVRange, Ctx); + StringRef Auto = std::isspace(*ReturnType.end()) // FIXME (dereferencing end) +

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

bernhardmgruber updated this revision to Diff 188621. bernhardmgruber marked 4 inline comments as done. bernhardmgruber retitled this revision from "[clang-tidy] modernize-use-trailing-return check" to "[clang-tidy] modernize-use-trailing-return-type check". bernhardmgruber added a comment. -