[PATCH] D56990: Bugfix for Replacement of tied operand of inline asm

This revision was automatically updated to reflect the committed changes. Closed by commit rC356196: [CodeGen] Consider tied operands when adjusting inline asm operands. (authored by efriedma, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D56990: Bugfix for Replacement of tied operand of inline asm

xiangzhangllvm added a comment. In D56990#1426977 , @efriedma wrote: > LGTM; I'll merge it tonight or tomorrow. Thank you very much! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56990/new/

[PATCH] D56990: Bugfix for Replacement of tied operand of inline asm

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM; I'll merge it tonight or tomorrow. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56990/new/ https://reviews.llvm.org/D56990

[PATCH] D56990: Bugfix for Replacement of tied operand of inline asm

xiangzhangllvm added a comment. We found may tests failed about this issue. I hope It can be committed. Thank you very much! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56990/new/ https://reviews.llvm.org/D56990

[PATCH] D56990: Bugfix for Replacement of tied operand of inline asm

xiangzhangllvm added a comment. Hi, efriedma could you help he commit this patch? Thank you very much! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56990/new/ https://reviews.llvm.org/D56990 ___ cfe-commits mailing

[PATCH] D56990: Bugfix for Replacement of tied operand of inline asm

xiangzhangllvm updated this revision to Diff 189979. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56990/new/ https://reviews.llvm.org/D56990 Files: lib/CodeGen/CGStmt.cpp test/CodeGen/asm-inout.c Index: test/CodeGen/asm-inout.c

[PATCH] D56990: Bugfix for Replacement of tied operand of inline asm

xiangzhangllvm added a comment. Thank you, efriedma But but the LLVM and Clang are different projects, I can commit the change at one time. I 'll update the patch for clang first. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56990/new/

[PATCH] D56990: Bugfix for Replacement of tied operand of inline asm

efriedma added a comment. We expect that tests for clang IR generation should look something like clang/test/CodeGen/asm-inout.c. Even though a test like that isn't directly testing the overall behavior, we try to separate tests of clang's behavior from tests of LLVM's behavior. It gives

[PATCH] D56990: Bugfix for Replacement of tied operand of inline asm

xiangzhangllvm added a comment. !!! Hi, dear efriedma, very sorry! I just saw your reply. line 2093: getTargetHooks().adjustInlineAsmType(... InputConstraint,...) will just deal with the constrain string, and it can't check the TiedOperand in the function. So, this will make inconsistent

[PATCH] D56990: Bugfix for Replacement of tied operand of inline asm

efriedma added inline comments. Comment at: test/Sema/inline-asm-x86-constraint.c:2 +// REQUIRES: x86-registered-target +// RUN: %clang_cc1 %s -o %t +typedef unsigned char __attribute__((vector_size(8))) _m64u8; Test belongs in test/CodeGen. Please use

[PATCH] D56990: Bugfix for Replacement of tied operand of inline asm

xiangzhangllvm added a comment. Hi dears, Could you please help me merge the patch. Thank you! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56990/new/ https://reviews.llvm.org/D56990 ___ cfe-commits mailing list

[PATCH] D56990: Bugfix for Replacement of tied operand of inline asm

xiangzhangllvm created this revision. xiangzhangllvm added reviewers: craig.topper, smaslov, LuoYuanke. xiangzhangllvm added a project: clang. Herald added subscribers: cfe-commits, eraman. The constraint "0" in the following asm did not consider the its relationship with "=y" when try to