[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).

This revision was automatically updated to reflect the committed changes. Closed by commit rL353380: [clangd] Suggest adding missing includes for typos (like include-fixer). (authored by ioeric, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: r

[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).

ioeric updated this revision to Diff 185718. ioeric marked 2 inline comments as done. ioeric added a comment. - Merge remote-tracking branch 'origin/master' into typo - address review comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57021/new/

[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Great stuff! Sorry for the delay here. Comment at: clangd/IncludeFixer.h:59 +SourceLocation Loc; // Start location of the unresolved name. +// Callback to get p

[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).

ioeric updated this revision to Diff 185546. ioeric marked 15 inline comments as done. ioeric added a comment. - address review comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57021/new/ https://reviews.llvm.org/D57021 Files: clangd/Clangd

[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).

sammccall added inline comments. Comment at: clangd/IncludeFixer.cpp:209 + std::vector Scopes; + if (Typo.SS) { +Scopes.push_back(*Typo.SS); ioeric wrote: > sammccall wrote: > > why do we do this here rather than compute the scopes/name already in > > Corr

[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).

ioeric added inline comments. Comment at: clangd/IncludeFixer.cpp:209 + std::vector Scopes; + if (Typo.SS) { +Scopes.push_back(*Typo.SS); sammccall wrote: > why do we do this here rather than compute the scopes/name already in > CorrectTypo()? > > Passing

[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).

ioeric updated this revision to Diff 185031. ioeric marked 13 inline comments as done. ioeric added a comment. Herald added a project: clang. - address review comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57021/new/ https://reviews.llvm.or

[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).

sammccall added inline comments. Comment at: clangd/IncludeFixer.cpp:74 +break; + default: +assert(RecordTypo); "default" looks a bit scary - could still end up with false positives. Can we cover a few of the most common cases (even if we know they're no

[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).

ioeric added a comment. Ping Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57021/new/ https://reviews.llvm.org/D57021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).

ioeric updated this revision to Diff 183845. ioeric added a comment. - Rebase on origin/master Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57021/new/ https://reviews.llvm.org/D57021 Files: clangd/ClangdUnit.cpp clangd/IncludeFixer.cpp clang

[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).

ioeric updated this revision to Diff 182925. ioeric added a comment. - Rebase on D56903 Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57021/new/ https://reviews.llvm.org/D57021 Files: clangd/ClangdUnit.cpp clan

[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).

ioeric updated this revision to Diff 182800. ioeric added a comment. - Rebase on D56903 . Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57021/new/ https://reviews.llvm.org/D57021 Files: clangd/ClangdUnit.cpp cla

[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).

ioeric updated this revision to Diff 182799. ioeric added a comment. - revert unintended change Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57021/new/ https://reviews.llvm.org/D57021 Files: clangd/CMakeLists.txt clangd/ClangdServer.cpp clan

[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).

ioeric created this revision. ioeric added a reviewer: sammccall. This adds include-fixer feature into clangd based on D56903 . Clangd now captures diagnostics caused by typos and attach include insertion fixes to potentially fix the typo. Repository: rCTE Cla