This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL363776: [RISCV] Mark TLS as supported (authored by
lewis-revill, committed by ).
Herald added a project: LLVM.
Herald adde
asb accepted this revision.
asb added a comment.
Herald added subscribers: Jim, benna, psnobl.
LGTM, thanks!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57055/new/
https://reviews.llvm.org/D57055
___
cfe-commits ma
lewis-revill updated this revision to Diff 185283.
lewis-revill added a comment.
Herald added a project: clang.
Added RISC-V to thread specifier test as a means of checking TLS is supported.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57055/new/
https://reviews
asb added a comment.
Could you add a test for this? I'm not sure if this is best done with a test
that uses __has_feature or otherwise (I note other targets don't seem to have
similar tests currently), but I think it would be handy.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://r
lewis-revill updated this revision to Diff 182920.
lewis-revill added a comment.
Rely on default value rather than explicitly marking `TLSSupported` as true.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57055/new/
https://reviews.llvm.org/D57055
Files:
lib/Ba
jrtc27 requested changes to this revision.
jrtc27 added inline comments.
This revision now requires changes to proceed.
Comment at: lib/Basic/Targets/RISCV.h:39
HasD(false), HasC(false) {
-TLSSupported = false;
+TLSSupported = true;
LongDoubleWidth = 128;
--
lewis-revill created this revision.
lewis-revill added a reviewer: asb.
Herald added subscribers: cfe-commits, jocewei, PkmX, rkruppe, the_o,
brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217,
kito-cheng, niosHD, sabuasal, apazos, simoncook, johnrusso, rbar.
Inform Cla
