rjmccall commandeered this revision.
rjmccall edited reviewers, added: bmoody; removed: rjmccall.
rjmccall added a comment.
This revision now requires review to proceed.
Committed as r358104, thanks for your patience.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
bmoody added a comment.
Herald added a subscriber: jdoerfert.
Herald added a project: clang.
Ping! Any chance you could commit this on my behalf? Otherwise I can try the
mailing list.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57072/new/
bmoody added a comment.
Great, I don't have commit access so you're welcome to commit on my behalf.
Thanks!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57072/new/
https://reviews.llvm.org/D57072
___
cfe-commits
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Sure, I have no objection to doing this at this point.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57072/new/
https://reviews.llvm.org/D57072
bmoody created this revision.
bmoody added reviewers: craig.topper, dberris, rjmccall.
Herald added a subscriber: cfe-commits.
This patch adds a check at the end of CodeGenFunction::FinishFunction to delete
the return block if it isn't reachable.
Without this patch applied the code generated
