[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new check

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE356801: [clang-tidy] openmp-use-default-none - a new check (authored by lebedevri, committed by ). Changed prior to commit: https://reviews.llvm.org/D57113?vs=191918&id=191927#toc Repository: rCTE

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new check

lebedev.ri added a comment. In D57113#1439890 , @aaron.ballman wrote: > LGTM aside from a minor diagnostic wording nit. Thank you for the review! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57113/new/ h

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new check

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a minor diagnostic wording nit. Comment at: clang-tidy/openmp/UseDefaultNoneCheck.cpp:52 + Clause->getDefaultKind()); +diag(Clause->getBeginLoc(), "e

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new check

lebedev.ri updated this revision to Diff 191918. lebedev.ri marked 5 inline comments as done. lebedev.ri added a comment. Make diags less grammatically correct, reduce docs. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57113/new/ https://reviews.ll

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new check

lebedev.ri added inline comments. Comment at: docs/clang-tidy/checks/openmp-use-default-none.rst:19 + +.. code-block:: c++ + aaron.ballman wrote: > This is a *lot* of example text -- are you sure all of it adds value, or can > some of it be removed? Right, let's

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new check

aaron.ballman added inline comments. Comment at: clang-tidy/openmp/UseDefaultNoneCheck.cpp:47-48 +diag(Directive->getBeginLoc(), + "OpenMP directive '%0' specifies 'default(%1)' clause. Consider using " + "'default(none)' clause instead.") +<< getOpen

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new check

lebedev.ri updated this revision to Diff 191869. lebedev.ri added a comment. Address some nits. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57113/new/ https://reviews.llvm.org/D57113 Files: clang-tidy/openmp/CMakeLists.txt clang-tidy/openmp/O

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new check

lebedev.ri updated this revision to Diff 191726. lebedev.ri marked 4 inline comments as done. lebedev.ri edited the summary of this revision. lebedev.ri added a reviewer: gribozavr. lebedev.ri added a comment. Rebased, NFC. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https:

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new check

lebedev.ri updated this revision to Diff 190973. lebedev.ri edited the summary of this revision. lebedev.ri added a comment. Rebased, NFC. Moved matchers into D59453 +D57112 . Repository: rCTE Clang Tools Extra CHANGES SINCE L

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new check

lebedev.ri updated this revision to Diff 184692. lebedev.ri retitled this revision from "[clang-tidy] openmp-use-default-none - a new module and a check" to "[clang-tidy] openmp-use-default-none - a new check". lebedev.ri edited the summary of this revision. lebedev.ri added a parent revision: D5