[PATCH] D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes

This revision was automatically updated to reflect the committed changes. Closed by commit rL352610: [clang] [Driver] [NetBSD] Append -rpath for shared compiler-rt runtimes (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes

dlj accepted this revision. dlj added a comment. In D57303#1373163 , @mgorny wrote: > Given that this path changes with every clang release, so you're effectively > making a hard dependency on the clang version used to build the program, I > dare say

[PATCH] D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes

mgorny added a comment. Given that this path changes with every clang release, so you're effectively making a hard dependency on the clang version used to build the program, I dare say some systems may either decide not to support shared runtimes at all or use `ld.so.conf` or equivalent that

[PATCH] D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes

krytarowski added a comment. In D57303#1373077 , @phosek wrote: > In D57303#1373061 , @krytarowski > wrote: > > > How do you resolve paths? Linker cache with registry of libraries? > > > `DT_NEEDED` aren't treated

[PATCH] D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes

phosek added a comment. In D57303#1373061 , @krytarowski wrote: > How do you resolve paths? Linker cache with registry of libraries? `DT_NEEDED` aren't treated as paths, they are used as object names (keys); dynamic linker passes those to the loader

[PATCH] D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes

krytarowski added a comment. In D57303#1373057 , @phosek wrote: > In D57303#1373035 , @krytarowski > wrote: > > > + vitalybuka > > > > Can we fix it for everybody? It's certainly not restricted to NetBSD. > > > As

[PATCH] D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes

phosek added a comment. In D57303#1373035 , @krytarowski wrote: > + vitalybuka > > Can we fix it for everybody? It's certainly not restricted to NetBSD. As a point of reference, we use shared runtimes on Fuchsia but we don't use rpath so this is not

[PATCH] D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57303/new/ https://reviews.llvm.org/D57303 ___ cfe-commits

[PATCH] D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes

krytarowski added a reviewer: vitalybuka. krytarowski added a comment. + vitalybuka Can we fix it for everybody? It's certainly not restricted to NetBSD. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57303/new/ https://reviews.llvm.org/D57303

[PATCH] D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes

mgorny created this revision. mgorny added reviewers: krytarowski, joerg, phosek, dlj. Herald added a subscriber: dberris. Append appropriate -rpath when using shared compiler-rt runtimes, e.g. '-fsanitize=address -shared-libasan'. There's already a similar logic in CommonArgs.cpp but it uses