efriedma added a comment.
Anyone looking at updating the datalayout for other platforms? (If nobody is
looking at all, I'll try to find some time next week, I guess.)
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57335/new/
https://reviews.llvm.org/D57335
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rL355522: [IR][ARM] Add function pointer alignment to
datalayout (authored by michaelplatings, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D57335?vs=188325&id=189524#toc
Repository:
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
Probably worth sending an email to llvmdev noting that the datalayout is
changing before you merge this, so a wider audience can review the IR aspects
of the change.
Otherwise LGTM
Repo
michaelplatings updated this revision to Diff 188325.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57335/new/
https://reviews.llvm.org/D57335
Files:
clang/lib/Basic/Targets/ARM.cpp
clang/test/CodeGen/armv7k-abi.c
clang/test/CodeGen/target-dat
michaelplatings updated this revision to Diff 188324.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57335/new/
https://reviews.llvm.org/D57335
Files:
clang/lib/Basic/Targets/ARM.cpp
clang/test/CodeGen/armv7k-abi.c
clang/test/CodeGen/target-dat
miyuki added inline comments.
Comment at: llvm/lib/IR/Value.cpp:651
if (auto *GO = dyn_cast(this)) {
// Don't make any assumptions about function pointer alignment. Some
// targets use the LSBs to store additional information.
This comment needs to b
efriedma added a subscriber: hfinkel.
efriedma added a comment.
Chandler, when you have a chance, can you look at the LangRef changes, since
you put some thought into the design?
I think the DataLayout/LangRef changes look correct.
I agree it isn't necessary to fix every target in the initial p
michaelplatings marked 4 inline comments as done.
michaelplatings added inline comments.
Comment at: llvm/lib/IR/ConstantFold.cpp:1087
+ if (GVAlign == 0U && isa(GV))
+GVAlign = 4U;
efriedma wrote:
> Using "4" as a default is dangerous; on
michaelplatings updated this revision to Diff 188184.
michaelplatings added a comment.
Herald added subscribers: cfe-commits, jdoerfert, mgorny, dschuff.
Herald added projects: clang, LLVM.
Hi @efriedma, sorry for the delayed response.
I've added the features you asked for to DataLayout.
It is int
