[PATCH] D57592: Replace uses of %T with %t in from previous frontend test differential

2019-02-03 Thread David Zarzycki via Phabricator via cfe-commits 
davezarzycki added a comment.

Hot fix: r352996


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57592/new/

https://reviews.llvm.org/D57592



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57592: Replace uses of %T with %t in from previous frontend test differential

2019-02-03 Thread Bruno Ricci via Phabricator via cfe-commits 
riccibruno added a comment.

> The NetBSD buildbot breaks in these tests now:

Pretty much every bot is red because of this patch 
(http://lab.llvm.org:8011/one_line_per_build) so yes, please fix.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57592/new/

https://reviews.llvm.org/D57592



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57592: Replace uses of %T with %t in from previous frontend test differential

2019-02-03 Thread Kamil Rytarowski via Phabricator via cfe-commits 
krytarowski added a comment.

The NetBSD buildbot breaks in these tests now:

http://lab.llvm.org:8011/builders/lldb-amd64-ninja-netbsd8/builds/18721

Both tests break in a similar way:

  Command Output (stderr):
  --
  + : 'RUN: at line 1'
  + not /home/motus/netbsd8/netbsd8/build/bin/clang -cc1 -internal-isystem 
/home/motus/netbsd8/netbsd8/build/lib/clang/9.0.0/include -nostdsysteminc 
-emit-llvm -o 
/home/motus/netbsd8/netbsd8/build/tools/clang/test/Frontend/Output/output-failures.c.tmp/doesnotexist/somename
 /home/motus/netbsd8/netbsd8/llvm/tools/clang/test/Frontend/output-failures.c
  + : 'RUN: at line 2'
  + /home/motus/netbsd8/netbsd8/build/bin/FileCheck -check-prefix=OUTPUTFAIL 
-input-file=/home/motus/netbsd8/netbsd8/build/tools/clang/test/Frontend/Output/output-failures.c.tmp
 /home/motus/netbsd8/netbsd8/llvm/tools/clang/test/Frontend/output-failures.c
  
/home/motus/netbsd8/netbsd8/llvm/tools/clang/test/Frontend/output-failures.c:4:16:
 error: OUTPUTFAIL: expected string not found in input
  // OUTPUTFAIL: error: unable to open output file 
'{{.*}}doesnotexist{{.}}somename': '{{[nN]}}o such file or directory'
 ^
  
/home/motus/netbsd8/netbsd8/build/tools/clang/test/Frontend/Output/output-failures.c.tmp:1:1:
 note: scanning from here
  error: unable to open output file 
'/home/motus/netbsd8/netbsd8/build/tools/clang/test/Frontend/Output/output-failures.c.tmp/doesnotexist/somename':
 'Not a directory'
  ^
  
/home/motus/netbsd8/netbsd8/build/tools/clang/test/Frontend/Output/output-failures.c.tmp:1:86:
 note: possible intended match here
  error: unable to open output file 
'/home/motus/netbsd8/netbsd8/build/tools/clang/test/Frontend/Output/output-failures.c.tmp/doesnotexist/somename':
 'Not a directory'

   ^
  
  --

Please fix.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57592/new/

https://reviews.llvm.org/D57592



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57592: Replace uses of %T with %t in from previous frontend test differential

2019-02-02 Thread Nico Weber via Phabricator via cfe-commits 
thakis added a comment.

Done, thanks for the patch!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57592/new/

https://reviews.llvm.org/D57592



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57592: Replace uses of %T with %t in from previous frontend test differential

2019-02-02 Thread Phabricator via Phabricator via cfe-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rL352971: Replace uses of %T with %t in from previous frontend 
test differential (authored by nico, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Changed prior to commit:
  https://reviews.llvm.org/D57592?vs=184768=184921#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57592/new/

https://reviews.llvm.org/D57592

Files:
  cfe/trunk/test/Frontend/output-failures.c
  cfe/trunk/test/Frontend/stats-file.c


Index: cfe/trunk/test/Frontend/stats-file.c
===
--- cfe/trunk/test/Frontend/stats-file.c
+++ cfe/trunk/test/Frontend/stats-file.c
@@ -4,5 +4,5 @@
 //  ... here come some json values ...
 // CHECK: }
 
-// RUN: %clang_cc1 -emit-llvm -o %t -stats-file=%T/doesnotexist/bla %s 2>&1 | 
FileCheck -check-prefix=OUTPUTFAIL %s
+// RUN: %clang_cc1 -emit-llvm -o %t -stats-file=%t/doesnotexist/bla %s 2>&1 | 
FileCheck -check-prefix=OUTPUTFAIL %s
 // OUTPUTFAIL: warning: unable to open statistics output file 
'{{.*}}doesnotexist{{.}}bla': '{{[Nn]}}o such file or directory'
Index: cfe/trunk/test/Frontend/output-failures.c
===
--- cfe/trunk/test/Frontend/output-failures.c
+++ cfe/trunk/test/Frontend/output-failures.c
@@ -1,4 +1,4 @@
-// RUN: not %clang_cc1 -emit-llvm -o %T/doesnotexist/somename %s 2> %t
+// RUN: not %clang_cc1 -emit-llvm -o %t/doesnotexist/somename %s 2> %t
 // RUN: FileCheck -check-prefix=OUTPUTFAIL -input-file=%t %s
 
 // OUTPUTFAIL: error: unable to open output file 
'{{.*}}doesnotexist{{.}}somename': '{{[nN]}}o such file or directory'


Index: cfe/trunk/test/Frontend/stats-file.c
===
--- cfe/trunk/test/Frontend/stats-file.c
+++ cfe/trunk/test/Frontend/stats-file.c
@@ -4,5 +4,5 @@
 //  ... here come some json values ...
 // CHECK: }
 
-// RUN: %clang_cc1 -emit-llvm -o %t -stats-file=%T/doesnotexist/bla %s 2>&1 | FileCheck -check-prefix=OUTPUTFAIL %s
+// RUN: %clang_cc1 -emit-llvm -o %t -stats-file=%t/doesnotexist/bla %s 2>&1 | FileCheck -check-prefix=OUTPUTFAIL %s
 // OUTPUTFAIL: warning: unable to open statistics output file '{{.*}}doesnotexist{{.}}bla': '{{[Nn]}}o such file or directory'
Index: cfe/trunk/test/Frontend/output-failures.c
===
--- cfe/trunk/test/Frontend/output-failures.c
+++ cfe/trunk/test/Frontend/output-failures.c
@@ -1,4 +1,4 @@
-// RUN: not %clang_cc1 -emit-llvm -o %T/doesnotexist/somename %s 2> %t
+// RUN: not %clang_cc1 -emit-llvm -o %t/doesnotexist/somename %s 2> %t
 // RUN: FileCheck -check-prefix=OUTPUTFAIL -input-file=%t %s
 
 // OUTPUTFAIL: error: unable to open output file '{{.*}}doesnotexist{{.}}somename': '{{[nN]}}o such file or directory'
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57592: Replace uses of %T with %t in from previous frontend test differential

2019-02-01 Thread Justice Adams via Phabricator via cfe-commits 
justice_adams added a comment.

@thakis thanks for the review. I don't have commit access, would you mind 
committing this for me?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57592/new/

https://reviews.llvm.org/D57592



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57592: Replace uses of %T with %t in from previous frontend test differential

2019-02-01 Thread Nico Weber via Phabricator via cfe-commits 
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Normally when needing a directory you'd `mkdir %t.dir` before using it, but 
since you don't' want the directory to exist here this should be good as-is. 
Thanks!


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57592/new/

https://reviews.llvm.org/D57592



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57592: Replace uses of %T with %t in from previous frontend test differential

2019-02-01 Thread Justice Adams via Phabricator via cfe-commits 
justice_adams added a comment.

@stella.stamenova These are the changes from our previous discussion regarding 
the usage of %T


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57592/new/

https://reviews.llvm.org/D57592



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits